From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3ACAFA04F0; Mon, 16 Dec 2019 18:40:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B566F288C; Mon, 16 Dec 2019 18:40:52 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 224791D9E for ; Mon, 16 Dec 2019 18:40:50 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 08:59:16 -0800 X-IronPort-AV: E=Sophos;i="5.69,322,1571727600"; d="scan'208";a="209363994" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Dec 2019 08:59:15 -0800 Date: Mon, 16 Dec 2019 16:59:10 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, olivier.matz@6wind.com, Ali Alnubani , David Marchand Message-ID: <20191216165910.GA452@bricha3-MOBL.ger.corp.intel.com> References: <20191216162242.1898285-1-thomas@monjalon.net> <20191216164011.GA445@bricha3-MOBL.ger.corp.intel.com> <1692365.TPV5GobrPX@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1692365.TPV5GobrPX@xps> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] devtools: avoid config backup during test build setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Dec 16, 2019 at 05:47:03PM +0100, Thomas Monjalon wrote: > 16/12/2019 17:40, Bruce Richardson: > > On Mon, Dec 16, 2019 at 05:22:42PM +0100, Thomas Monjalon wrote: > > > The config options are updated with sed and the short inline option. > > > In FreeBSD, the suffix argument of the inline option is mandatory. > > > In order to avoid creating a backup file when using sed inline, > > > the argument is set as an empty suffix. > > > > > > The short option '-i' does not expect '=' before the suffix argument, > > > so it understands '=' as the file suffix. > > > As a consequence, a backup file named '.config=' was created > > > in the build directory. > > > > > > Removing the '=' sign while keeping an empty suffix > > > avoids creating a backup file. > > > > > > Fixes: 4a4a20c4775b ("devtools: support FreeBSD") > > > Cc: olivier.matz@6wind.com > > > Cc: stable@dpdk.org > > > > > > Reported-by: Ali Alnubani > > > Signed-off-by: Thomas Monjalon > > > --- > > > > > > This patch does not work on FreeBSD. > > > Does it mean the equal sign is required on FreeBSD? > > > This is not what I see on the documentation: > > > https://www.freebsd.org/cgi/man.cgi?query=sed&sektion=&n=1 > > > > > > --- > > > > It appears it is needed, which is why the "=" was added in the first place. > > See commit: 4a4a20c4775b ("devtools: support FreeBSD"), by Olivier > > > > Is having the backup file a big issue? > > No it's not a big issue. > But I really would like to know how to have a common behaviour on BSD an Linux > for a thing as simple as "sed -i" ! > And why the mandatory "=" is not documented on FreeBSD? > > It cannot be so much broken. We probably miss something... > I think FreeBSD just requires a space between the -i and the ''. Testing that seems to work for me on BSD. I assume it also should work on Linux. /Bruce