From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C14C3A0510; Wed, 18 Dec 2019 17:08:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE4B81C01; Wed, 18 Dec 2019 17:08:08 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 91D92F90; Wed, 18 Dec 2019 17:08:06 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 08:08:05 -0800 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="210130927" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.5.60]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Dec 2019 08:08:02 -0800 Date: Wed, 18 Dec 2019 16:07:58 +0000 From: Bruce Richardson To: Reshma Pattan Cc: dev@dpdk.org, stable@dpdk.org, Nikhil Rao , Chas Williams , Stephen Hemminger Message-ID: <20191218160758.GA474@bricha3-MOBL.ger.corp.intel.com> References: <20191025153808.31753-1-reshma.pattan@intel.com> <20191218115831.4035-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191218115831.4035-1-reshma.pattan@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v4] app/test: fix build when ring PMD is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 18, 2019 at 11:58:31AM +0000, Reshma Pattan wrote: > Some unit tests has dependency on RING PMD, > so this patch is trying to fix those and other > closely related issues. > > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter > unit tests are dependent on ring PMD, so compile those > tests only when ring PMD is enabled else ignore. > > 2)get rid of make file error which was added by bond unit test > for ring PMD disabled case which is not necessary. > > 3)Tx adapter UT is dependent on RING PMD, but it was > observed that it was missing from the run in meson > build, so added it. TX adapter UT uses 'sw event and > 'null' pmd drivers, so for shared builds the drivers .so > path has to be passed to the test args of meson UT run. > > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") > Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library") > Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats library") > Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter") > Fixes: d23e09e0ef ("app/test: link with ring pmd when needed") > > CC: stable@dpdk.org > CC: Nikhil Rao > CC: Chas Williams > CC: Bruce Richardson > CC: Stephen Hemminger > > Reported-by: Stephen Hemminger > Signed-off-by: Reshma Pattan > --- > v4: fix event_eth_tx_adapter_autotest for shared build > as reported by travis-ci > https://travis-ci.com/ovsrobot/dpdk/jobs/249598391 > v3: add missing test event_eth_tx_adapter_autotest. > Add link bonding mode4 test to drivers test. > v2: fix comments of v1 and combine the patches 1/2 and 2/2 of v1 > --- > app/test/Makefile | 16 +++++----------- > app/test/meson.build | 37 +++++++++++++++++++++++-------------- > app/test/process.h | 8 ++++++++ > app/test/test.c | 2 ++ > 4 files changed, 38 insertions(+), 25 deletions(-) > > > test_args = [num_cores_arg] > + > + One blank line is probably enough. > foreach arg : fast_test_names > + if (get_option('default_library') == 'shared' and > + arg == 'event_eth_tx_adapter_autotest') > + foreach drv:dpdk_drivers > + test_args += ['-d', drv.full_path().split('.a')[0] + '.so'] > + endforeach > + endif Does this need to be limited to just this one test? Why not just set the test args outside the loop to always include all drivers if it is a shared build? /Bruce