From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 9A8196CD1
 for <dev@dpdk.org>; Fri,  9 Sep 2016 14:40:29 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id 1so30637212wmz.1
 for <dev@dpdk.org>; Fri, 09 Sep 2016 05:40:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=1aJU9nPGH0LeiQ8zkONYj7lgXT3XnmwHqxIm7gdvpz8=;
 b=fUERwS08h7Df5+8V1sTEpup2i9jnDNoRMVAdmUidKdeLfLq0dYy/NbcVVswbNfqkkk
 xmnGLUXCjAtwEAC6GRmV+tlKSYUjQWcBhT8t+xjl59cCd9SxsyJvfnFDlbIKrfCMOom3
 +D/Y6FIpT5ORxBT58shSdA8zIYmJLuQjb4uhinWFCFFLoiA/3N8x8TlvByu2iVI+TAWe
 KrGD7Fjq/qg0fuDulL5a2AfLnbcJZFyJciVB8cVleOdgN40DgN20vf/gt/BfseWDCQ0s
 tBbBAS8+JvZA3J9+752+f770mR7Ss67lw0YXqSTaQ3oAJmVQ04nsCdH05VttT4Ror3wT
 m0jg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=1aJU9nPGH0LeiQ8zkONYj7lgXT3XnmwHqxIm7gdvpz8=;
 b=JZlb4hAY5DNW9TtaGaL1uXBIhROiDnFnW2F7/pgVsCBDr3NhjOrduwNY37JusrNaey
 2BxTVcrkjOv83QsP6yxYSV/kVgJFS9jH9CaDZP+MxipuWNW1U+h8sxG2XWmZO4pNduCh
 iD/0jIWuoBvaiqoN+QJ8serMRBmEKTQLoQI/EIQCE/uKvzY4BAM3P9sdNg75aB/VRBd8
 6dqA6OOSUcTb1U6mhNu5qv5NiIn7hnQoxQzv6k7k1EKIxUZFCwA9CeUyR5B88RjpTRic
 8PqOjRytI9JleW8FKosvEoER/2PJjHynlNE/cYdh79cXgh+OeTOx3W9kXnR2PhxkG15p
 7QoQ==
X-Gm-Message-State: AE9vXwOnZIrzW+/D7tY8IZBZNV+i/Dywz7u4jZn6PCvcRkFROqo0/sZcNNKBKQReZk7EnKc2
X-Received: by 10.28.55.67 with SMTP id e64mr2929764wma.107.1473424829252;
 Fri, 09 Sep 2016 05:40:29 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id i127sm2559799wmf.4.2016.09.09.05.40.27
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 09 Sep 2016 05:40:28 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 zhouyangchao <zhouyates@gmail.com>, dev@dpdk.org
Date: Fri, 09 Sep 2016 14:40:27 +0200
Message-ID: <2019611.627KgLZ47A@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <05b14d74-b168-69b2-b107-124ee951dc27@intel.com>
References: <1473389167-2758-1-git-send-email-zhouyates@gmail.com>
 <20160908094442.4dfa5b01@xeon-e3>
 <05b14d74-b168-69b2-b107-124ee951dc27@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device
	could cause a kernel crash
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Sep 2016 12:40:29 -0000

2016-09-08 18:15, Ferruh Yigit:
> On 9/8/2016 5:44 PM, Stephen Hemminger wrote:
> 
> ...
> 
> > But then again the whole KNI driver fails completely when
> > running kernel style check.
> > 
> 
> Yes, it generates lots of warnings.
> I can fix them (excluding ethtool/*), that wouldn't take much time but
> how syntax only patches welcomed? Another concern is it trashes git blame.

You ask a question and give the answer ;)
I think it depends just on the balance of the pros/cons - to be evaluated.