From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B817DA046B for <public@inbox.dpdk.org>; Mon, 22 Jul 2019 14:09:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 496B51BECB; Mon, 22 Jul 2019 14:09:23 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 8F9A61B950 for <dev@dpdk.org>; Mon, 22 Jul 2019 14:09:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EE8502099D; Mon, 22 Jul 2019 08:09:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Jul 2019 08:09:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MpoHC1tCcTSBzOwB/2p7CXiUgH4V+oBXWoUcIxw22AY=; b=LUyX0AUdzEJK kgsEPfehpqb/X5FOJjvpHwUs00qYNs2ydmhVQt6+hJMqCRU5NHTOVjghAm0j8tgm MV7d2i3QdVr7+VpbEd8kjjFvgoZEncePOF4Vehzehmgn0c5ykXvyrNeRqNQElIh+ JL8Z1zTdbbr3u/KUTMAGErb7l1R6c7U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=MpoHC1tCcTSBzOwB/2p7CXiUgH4V+oBXWoUcIxw22 AY=; b=RKKHE8IDqndivZFBZEf4Xg0Lki3yfk4yXFFDUkfNlVqLTvks84Id1VVCJ 49Q5+g275YAeeonybnnxyAq1v+onD9jZ2YmFKT3A9/ysDtBv/ECJJGIycraZOrsT UT/cku4D1B4GfE4KLfsv8RgbFoN892fjLxMydoZPLhZcwsb/9M1p5n1WjNoUb1DP QErKb7uGd0ONMVy65ygOJEEIG+cVErHOyK9hxwIYuHU6RFmzvPPW9gXeRxHE6ZV7 bF9NSMBK2sz6ZyuHzO8lQBo2qzS8O+nRPBXMXzH+mtCRhEAmq4YuXqTtH2FYftv3 EgBFR1D8+EAV49sJrEO/V4zdkl6Iw== X-ME-Sender: <xms:cKc1XRydSYm16DOGTjMy-5uSEcQlvsY6nx6T1-KmlOrlO0wpEhNRyA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrjeeggdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:cKc1Xc2zYHsOjv-VT8cMff-vbALG1bZv4TZ1a0TDtk674Lb0jZXfLw> <xmx:cKc1XbVYrb6q7zgvnrtHmsOXnz5gRKycPXIvPf33iruPUC7ZI4UIkw> <xmx:cKc1XYdWrqyHK1En56R4XwYQ9NgGgMGPS-ClXn19g-LZhiuCxwk7SQ> <xmx:cac1XZr4tPmDWce9pOawFpyWJN5zvf1S0vY2rvBGImOugLB_2WBKlg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 37CC880063; Mon, 22 Jul 2019 08:09:20 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Raslan Darawsheh <rasland@mellanox.com>, Stephen Hemminger <stephen@networkplumber.org>, Bernard Iremonger <bernard.iremonger@intel.com> Date: Mon, 22 Jul 2019 14:09:18 +0200 Message-ID: <2019800.YxjaKc8hKA@xps> In-Reply-To: <DB3PR0502MB396461E4F5226E33A2903A50C2C50@DB3PR0502MB3964.eurprd05.prod.outlook.com> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190708182614.1677-8-stephen@networkplumber.org> <DB3PR0502MB396461E4F5226E33A2903A50C2C50@DB3PR0502MB3964.eurprd05.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 07/11] app/testpmd: use new ethernet address parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 21/07/2019 15:42, Raslan Darawsheh: > Hi Guys, > > We have a failure in testpmd commands when parsing rte_flow commands as following which were interduce by this patch: > > This rule is a valid rule to be added to testpmd: > flow validate 0 priority 2 ingress group 0 pattern eth dst is 98:03:9B:5C:D9:00 / end actions queue index 0 / end > > but, currently with latest master it will fail with Bad arguments > > the check for get_ether_addr6/3 is expecting that you reach the end of string when it parse a MAC address but for rte_flow commands it's not the case, > since we provide the full string: > gdb) p s > $3 = 0x28225fa "98:03:9B:5C:D9:00 / end actions queue index 0 / end\n" Ferruh, it seems this patch must be reverted. We probably need to adapt testpmd to the new function and properly test it. Let's target it for -rc3 or 19.11.