From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Andy Pei <andy.pei@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com,
rosen.xu@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ipn3ke: fix line side statistics register read
Date: Fri, 3 Jan 2020 15:43:40 +0800 [thread overview]
Message-ID: <20200103074340.GL14498@intel.com> (raw)
In-Reply-To: <1577775227-287186-1-git-send-email-andy.pei@intel.com>
On 12/31, Andy Pei wrote:
>To read line side statistics register, eth_group_sel
>args in function ipn3ke_indirect_mac_read should be 0.
>When eth_group_sel is 1, the nic side register is read.
>
>Fixes: 5a6d883878db ("net/ipn3ke: implement statistics")
>Cc: andy.pei@intel.com
>Cc: stable@dpdk.org
>
>Signed-off-by: Andy Pei <andy.pei@intel.com>
>---
>Cc: ferruh.yigit@intel.com
>Cc: rosen.xu@intel.com
>Cc: xiaolong.ye@intel.com
>
> drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
>index 8d9ebef..80122e3 100644
>--- a/drivers/net/ipn3ke/ipn3ke_representor.c
>+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
>@@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
> &tmp,
> IPN3KE_25G_TX_STATISTICS_STATUS,
> port_id,
>- 1);
>+ 0);
> if (tmp & IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
> tmp = 0x00000000;
> (*hw->f_mac_read)(hw,
>--
>1.8.3.1
>
Applied to dpdk-next-net-intel, Thanks.
prev parent reply other threads:[~2020-01-03 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 6:53 Andy Pei
2020-01-02 0:36 ` Xu, Rosen
2020-01-03 7:43 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103074340.GL14498@intel.com \
--to=xiaolong.ye@intel.com \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).