From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1645FA04F3; Fri, 3 Jan 2020 14:55:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF5821D41E; Fri, 3 Jan 2020 14:55:28 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 276921D41C; Fri, 3 Jan 2020 14:55:27 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2020 05:55:25 -0800 X-IronPort-AV: E=Sophos;i="5.69,390,1571727600"; d="scan'208";a="210093808" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.26]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 Jan 2020 05:55:24 -0800 Date: Fri, 3 Jan 2020 13:55:21 +0000 From: Bruce Richardson To: david.marchand@redhat.com Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20200103135521.GA570@bricha3-MOBL.ger.corp.intel.com> References: <20191217140838.2711906-1-bruce.richardson@intel.com> <20191223103840.2848732-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191223103840.2848732-1-bruce.richardson@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v2] build: explicitly enable sse4 for meson builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" +stable This patch is probably worthwhile taking into 19.11 and 18.11 branches to reduce chances of failures on CI of stable trees. On Mon, Dec 23, 2019 at 10:38:40AM +0000, Bruce Richardson wrote: > If the compiler does not recognise the specific CPU when building with the > default "native" machine type, sse4.2 instructions can be missing, causing > a build error. Rather than advising the user to change the machine type, > we can just turn on SSE4.2 directly. This can prevent issues with running > automated tests with older compilers/distros on newer hardware. > Cc: stable@dpdk.org > Signed-off-by: Bruce Richardson > --- > V2: insert missing quotes around "-msse4" > --- > config/x86/meson.build | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/config/x86/meson.build b/config/x86/meson.build > index 8b0fa3e6f..adc857ba2 100644 > --- a/config/x86/meson.build > +++ b/config/x86/meson.build > @@ -15,11 +15,9 @@ if not is_windows > endif > > # we require SSE4.2 for DPDK > -sse_errormsg = '''SSE4.2 instruction set is required for DPDK. > -Please set the machine type to "nehalem" or "corei7" or higher value''' > - > if cc.get_define('__SSE4_2__', args: machine_args) == '' > - error(sse_errormsg) > + message('SSE 4.2 not enabled by default, explicitly enabling') > + machine_args += '-msse4' > endif > > base_flags = ['SSE', 'SSE2', 'SSE3','SSSE3', 'SSE4_1', 'SSE4_2'] > -- > 2.24.1 >