From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56DFDA04F7; Tue, 7 Jan 2020 02:42:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DF581D8D9; Tue, 7 Jan 2020 02:41:59 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id BE0331D8D1; Tue, 7 Jan 2020 02:41:56 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jan 2020 17:41:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,404,1571727600"; d="scan'208";a="303044272" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga001.jf.intel.com with ESMTP; 06 Jan 2020 17:41:53 -0800 Date: Tue, 7 Jan 2020 09:41:56 +0800 From: Tiwei Bie To: Stephen Hemminger Cc: dev@dpdk.org, jianfeng.tan@intel.com, stable@dpdk.org Message-ID: <20200107014156.GA84262@___> References: <20200106191837.29076-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200106191837.29076-1-stephen@networkplumber.org> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio_user: do not close invalid file descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 06, 2020 at 11:18:37AM -0800, Stephen Hemminger wrote: > Valgrind complains that virtio_user is calling close(-1). > Fix this by adding check in virtio that is similar to existing code. > > Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer") > Cc: jianfeng.tan@intel.com > Cc: stable@dpdk.org > Signed-off-by: Stephen Hemminger > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Tiwei Bie