From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD7D3A04F3; Thu, 9 Jan 2020 07:36:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2519C1DB93; Thu, 9 Jan 2020 07:36:09 +0100 (CET) Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id 81DC21DB90 for ; Thu, 9 Jan 2020 07:36:08 +0100 (CET) Received: by mail-pj1-f67.google.com with SMTP id s94so619334pjc.1 for ; Wed, 08 Jan 2020 22:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fh6sp5utUFkNF/uop1ahyinOEJjG3niDVwWe99Xsy7U=; b=kJuLQTS2TK4Kz/IddSTsmK3mwmEm2EzdQZ0XbRhUXqJfnxh9nXcPHBsfeLPrcFuF+3 zrAdpE0GJeXlQwNf+sPI2LiD4Pz2gWFfPHSAEbfimILvUcahmArr2Zcaykx8fcqRJF1h 4msqha9L5huyFbIf/yYW+zuq4aS+on74CTdr/D6ThFCRh1y543iaBFJHP/kYlvIX8R3x OZFd5F9tZFeehKqD5rlvpRJ2Pj+IxO83kwociLl4OmjGmYKJeq+V4KomkiohBstxyEW7 5mUMNmHH1lIXqwryhOv89Ih5omwrVmtSGCyShaU9S3V30qhpfLzQAcCh+FNnCgwFnu4H BvMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fh6sp5utUFkNF/uop1ahyinOEJjG3niDVwWe99Xsy7U=; b=eiAqN4ll4C3+14Iaa4S5iLQlw9kI7bi+YLIVdfcfJCUcNDtUO6y52/MzjHld7yNr3d sFNjNYvekRECM2fU5v+l8puwfoZavfxPXexg65kFohm5GwqrNi/I5TWAsb+gqbcfvGp7 3EZ5ybcBzkr09pzAgtKgSuz8qVHmXmiq5vkodoSXCo10IYyGXgH6mdb3CY9lgZH/b72y 8J/m28IroM/3czVkEnIpyeHXoHbtzfXaPC/QlNm1p6OSCRTaVfyNG/4NcfUnS4ETJta2 ZSI+A7RQmZILpluUpSu3H6qQJP1nzP/WasmLDWALqx1PpVEjMIPqEPR9j5h4MjWDO/aT ME9w== X-Gm-Message-State: APjAAAVF6WBtI8wVZy9v3O+YPzSNu/hoa+8jffzPeoRiTRoe9Cvplx6k RwyWFILzvA2h7m8O+wVcd1iRBw== X-Google-Smtp-Source: APXvYqyDUwB7JOyoUPF6vx+twUFGWscKh9V6lz65D9x3Z5wf/KOOz2Cb+srZ6HQH5tfNlgi7c7A/tw== X-Received: by 2002:a17:90a:1785:: with SMTP id q5mr3425999pja.143.1578551767587; Wed, 08 Jan 2020 22:36:07 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g8sm6045039pfh.43.2020.01.08.22.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2020 22:36:07 -0800 (PST) Date: Wed, 8 Jan 2020 22:35:57 -0800 From: Stephen Hemminger To: Pallavi Kadam Cc: dev@dpdk.org, thomas@monjalon.net, Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinjacobk@gmail.com, ranjit.menon@intel.com, antara.ganesh.kolar@intel.com Message-ID: <20200108223557.42244512@hermes.lan> In-Reply-To: <20200109031312.6344-7-pallavi.kadam@intel.com> References: <20191022200227.1920-1-pallavi.kadam@intel.com> <20200109031312.6344-1-pallavi.kadam@intel.com> <20200109031312.6344-7-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 6/9] eal: add function to detect process type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 8 Jan 2020 19:13:09 -0800 Pallavi Kadam wrote: Minor comments > /* Address of global and public configuration */ > -static struct rte_config rte_config; > +static struct rte_config rte_config = { > + .mem_config = &early_mem_config, > +}; Only single tab is needed for indent here +enum rte_proc_type_t + eal_proc_type_detect(void) put function in column 1. enum rte_proc_type_t eal_proc_type_detect(void) In a related vain, the existing code fore eal_create_cpu_map does not follow DPDK coding style at all. It has weird indentation of for loops and uses C99 style declarations of loop variables. I guess nobody on Linux side ever looked at the Windows code for that.