DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Phil Yang <phil.yang@arm.com>, Gavin Hu <gavin.hu@arm.com>,
	Dharmik Thakkar <dharmik.thakkar@arm.com>,
	dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix build for gcc 4.8.5
Date: Wed, 15 Jan 2020 18:17:45 +0800	[thread overview]
Message-ID: <20200115101745.GF33538@intel.com> (raw)
In-Reply-To: <20200114175247.2930261-1-ferruh.yigit@intel.com>

On 01/14, Ferruh Yigit wrote:
>Build error:
>  In function ‘ixgbe_recv_pkts_lro_bulk_alloc’:
>../drivers/net/ixgbe/ixgbe_rxtx.c:2209:24:
>  error: ‘next_sc_entry’ may be used uninitialized in this function
>  [-Werror=maybe-uninitialized]
>    next_sc_entry->fbuf = first_seg;
>                        ^
>http://mails.dpdk.org/archives/test-report/2020-January/113891.html
>
>This is a compiler false positive and error not seen by newer compilers,
>or clang but to fix the warning initializing the complained variable.
>
>According git bisect, no idea how:
>Fixes: 8a2e7ce976fd ("net/ixgbe: avoid multiple definitions of bool")
>
>Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>---
>Cc: dharmik.thakkar@arm.com
>---
> drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
>index 13b06eb9c..30f890572 100644
>--- a/drivers/net/ixgbe/ixgbe_rxtx.c
>+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
>@@ -2028,7 +2028,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,
> 		bool eop;
> 		struct ixgbe_rx_entry *rxe;
> 		struct ixgbe_scattered_rx_entry *sc_entry;
>-		struct ixgbe_scattered_rx_entry *next_sc_entry;
>+		struct ixgbe_scattered_rx_entry *next_sc_entry = NULL;
> 		struct ixgbe_rx_entry *next_rxe = NULL;
> 		struct rte_mbuf *first_seg;
> 		struct rte_mbuf *rxm;
>-- 
>2.24.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

  parent reply	other threads:[~2020-01-15 10:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 17:52 Ferruh Yigit
2020-01-14 18:01 ` Maxime Coquelin
2020-01-15 10:17 ` Ye Xiaolong [this message]
2020-01-15 16:50   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200115101745.GF33538@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=dharmik.thakkar@arm.com \
    --cc=ferruh.yigit@intel.com \
    --cc=gavin.hu@arm.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=phil.yang@arm.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).