From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AFB9A051C; Sat, 18 Jan 2020 02:53:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7BFB62B9E; Sat, 18 Jan 2020 02:53:10 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 17F6829C6 for ; Sat, 18 Jan 2020 02:53:07 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 17:52:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,332,1574150400"; d="scan'208";a="306414547" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga001.jf.intel.com with ESMTP; 17 Jan 2020 17:52:19 -0800 Date: Sat, 18 Jan 2020 09:52:05 +0800 From: Ye Xiaolong To: "Mcnamara, John" Cc: "Kovacevic, Marko" , "dev@dpdk.org" , "Richardson, Bruce" , Stephen Hemminger Message-ID: <20200118015205.GO33538@intel.com> References: <20191129081911.92988-1-xiaolong.ye@intel.com> <20191216030109.99125-1-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4] doc: introduce openwrt how-to guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, John Thanks for your review. On 01/17, Mcnamara, John wrote: >Hi, > >Overall looks good. Some notes below: > >> + >> +.. note:: >> + >> +For compiling the NUMA lib, run libtool --version to ensure the >> +libtool version >= 2.2, otherwise the compilation will fail with errors. > > >This continuation line isn't indented and raised a build error: > > $ make doc-guides-html > sphinx processing guides-html... > /work/dpdk_docs/doc/guides/howto/openwrt.rst:80: WARNING: > Explicit markup ends without a blank line; unexpected unindent. > >Also you should used spaces not tabs for indentation in the docs. Got it. > >> +If you are using Windows PC, you can use some free and opensource raw >> +disk image writer program such as >> +``Win32 Disk Imager`` and ``Etcher`` to write OpenWrt image >> +(openwrt-x86-64-combined-ext4.img) to a USB flash driver or USB SDcard >> with SDcard or a Sata hard drivre or SSD from your PC. > >Typo: drive > >I'll send you a few other suggested minor corrections. I'll send a new version after I correct all the suggestions. Thanks, Xiaolong > >John >