From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C69AA04DD; Tue, 21 Jan 2020 17:22:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9415F4C90; Tue, 21 Jan 2020 17:22:08 +0100 (CET) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 8DC944C74 for ; Tue, 21 Jan 2020 17:22:06 +0100 (CET) Received: by mail-pl1-f194.google.com with SMTP id g6so1538668plp.6 for ; Tue, 21 Jan 2020 08:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ppm3LLv/4wN/Cgl8oMkUyZy7rWOOJbdNnwWyulAjVjo=; b=MWFbl9nVN4IiQDNFuNzowElHUuvlaRnHDhKgxXC62BAhdQZL11vI9CAdeXSAkeDKYk BBgNJr1wxP3adKvZ8Mt8sAWCKei0qTgrfpoKQWi9syZxsepn//OGFUM+aAI0WLKG9ue1 rSJoJcb8AQ96vUWtrojwSCNnHk2eAfzxMOd7l+MVQc5LUIuDA3o/k4VSGLKr/NTLjisI MhRZSaY0QQZ2hdYRl88+pQmK+7eE7Zu27pLGyJbPfS5dFaSH/pREICKqdejeV33d27fB vV47oPJn59Uk7srxwoEsSrOWfjdHkOn9oqebNSDsrx4YblnxSXQfIz/dA368j9WYBbfC q+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ppm3LLv/4wN/Cgl8oMkUyZy7rWOOJbdNnwWyulAjVjo=; b=XehVzxE0luu9zwrU49dJrpKuEOhJaKqPwa6ka0+l5srX9qn3g6dz2BsUpOWdEAcpq/ uhSisTGnWkFbpL3xgEpWeFHQwZi8EzM8w5pXkYchbedhHjkVriHc+gBZPmwq58cvoK+F tJPAwE8oEFgcQWIHSu4d3k/7r8BJnP19IXPTJbZpzS2+qOQ3n6hzsZvDPpshXgXUhk6o cANsfN5jd4e0+Yigncgc/UO2eg455EUGvkyFelee+OkBlyaJmyU8OiY8XYMtdLrguvLL tYICwc273eyB6N9IQL+5kpz8sMcVLQ6YEN6KLzdiRhKgk9j3S0AR9vuEMUPaubNYl6HL aIHQ== X-Gm-Message-State: APjAAAVhVlv3k6hcy5PeCBmzHX87t2mzDNKZDqFFDTtlXGduvtAtGvi4 zTQbDR8nZFeHNsvU0MPnyivjxw== X-Google-Smtp-Source: APXvYqz80Id6gHaMOrm5cy+uKQaS4tHEHCJp1+QT5GVXQkYsceTwPC4FK4l+2bQTrPnE94GSMwznlw== X-Received: by 2002:a17:902:fe0d:: with SMTP id g13mr6180077plj.277.1579623725561; Tue, 21 Jan 2020 08:22:05 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j14sm41478644pgs.57.2020.01.21.08.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 08:22:05 -0800 (PST) Date: Tue, 21 Jan 2020 08:21:56 -0800 From: Stephen Hemminger To: Olivier Matz Cc: Slava Ovsiienko , "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh , Ori Kam , Shahaf Shuler , "thomas@mellanox.net" Message-ID: <20200121082156.179e3681@hermes.lan> In-Reply-To: <20200121140157.GP14387@glumotte.dev.6wind.com> References: <20191118094938.192850-1-shahafs@mellanox.com> <1579541003-2399-1-git-send-email-viacheslavo@mellanox.com> <1579541003-2399-2-git-send-email-viacheslavo@mellanox.com> <20200120124342.6b308e18@hermes.lan> <20200121081417.GO14387@glumotte.dev.6wind.com> <20200121140157.GP14387@glumotte.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/5] mbuf: introduce routine to get private mbuf pool flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 21 Jan 2020 15:01:57 +0100 Olivier Matz wrote: > > I've checked the rte_mempool_get_priv() usage - in all header files there > > are the type casts. The "rte_mbuf.h" contains the rte_pktmbuf_priv_size() and > > rte_pktmbuf_data_room_size(), both provide the cast. What is the reason? > > C++ compatibility? Should we remove the cast in rte_pktmbuf_priv_flags()? > > Removing the cast will certainly break C++ code using this header. > There is a similar case in commit a2ff2827dc84 ("mbuf: fix C++ build on > void pointer cast") > > In my opinion it can stay as it is now. Agreed. Thanks for trying.