From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id B466CA04DD;
Tue, 21 Jan 2020 12:45:06 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 0C0AD4C7B;
Tue, 21 Jan 2020 12:44:54 +0100 (CET)
Received: from incedge.chinasoftinc.com (unknown [114.113.233.8])
by dpdk.org (Postfix) with ESMTP id EFC3B322C
for <dev@dpdk.org>; Tue, 21 Jan 2020 12:44:48 +0100 (CET)
X-ASG-Debug-ID: 1579607080-0a3dd173f383950004-TfluYd
Received: from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by
incedge.chinasoftinc.com with ESMTP id 21fXzHlG4oF4UzdN (version=TLSv1
cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;
Tue, 21 Jan 2020 19:44:46 +0800 (CST)
X-Barracuda-Envelope-From: huwei013@chinasoftinc.com
X-Barracuda-RBL-Trusted-Forwarder: 10.168.0.52
X-ASG-Whitelist: Client
Received: from localhost.localdomain (114.119.4.74) by INCCAS002.ito.icss
(10.168.0.60) with Microsoft SMTP Server id 14.3.439.0; Tue, 21 Jan 2020
19:44:40 +0800
From: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>
X-Barracuda-RBL-Trusted-Forwarder: 10.168.0.60
To: <dev@dpdk.org>
Date: Tue, 21 Jan 2020 19:44:33 +0800
X-ASG-Orig-Subj: [PATCH 3/3] app/testpmd: fix uninitialized members when
setting PFC
Message-ID: <20200121114433.57543-4-huwei013@chinasoftinc.com>
X-Mailer: git-send-email 2.23.0
In-Reply-To: <20200121114433.57543-1-huwei013@chinasoftinc.com>
References: <20200121114433.57543-1-huwei013@chinasoftinc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [114.119.4.74]
X-Barracuda-Connect: inccas002.ito.icss[10.168.0.52]
X-Barracuda-Start-Time: 1579607084
X-Barracuda-Encrypted: ECDHE-RSA-AES256-SHA
X-Barracuda-URL: https://spam.chinasoftinc.com:443/cgi-mod/mark.cgi
X-Virus-Scanned: by bsmtpd at chinasoftinc.com
X-Barracuda-Scan-Msg-Size: 1384
Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: fix uninitialized members when
setting PFC
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Only a part of members in the local structure variable named pfc_conf are
initialized in the function named cmd_priority_flow_ctrl_set_parsed when
typing "set pfc_ctrl..." command, and others are random values. However,
those uninitialized members may cause failure.
This patch adds clearing zero operation before calling the API named
rte_eth_dev_priority_flow_ctrl_set API with pfc_conf as the input
parameter.
Fixes: 9b53e542e9e1 ("app/testpmd: add priority flow control")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Xuan Li <lixuan47@hisilicon.com>
---
app/test-pmd/cmdline.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index a09cb87e1..b6d8ef0f0 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -7090,6 +7090,7 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result,
{RTE_FC_NONE, RTE_FC_TX_PAUSE}, {RTE_FC_RX_PAUSE, RTE_FC_FULL}
};
+ memset(&pfc_conf, 0, sizeof(struct rte_eth_pfc_conf));
rx_fc_enable = (!strncmp(res->rx_pfc_mode, "on",2)) ? 1 : 0;
tx_fc_enable = (!strncmp(res->tx_pfc_mode, "on",2)) ? 1 : 0;
pfc_conf.fc.mode = rx_tx_onoff_2_pfc_mode[rx_fc_enable][tx_fc_enable];
--
2.23.0