From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A539A04DD; Tue, 21 Jan 2020 14:48:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60F171515; Tue, 21 Jan 2020 14:48:41 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 5A1EC1252 for ; Tue, 21 Jan 2020 14:48:40 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id p9so3029290wmc.2 for ; Tue, 21 Jan 2020 05:48:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=exla7Pi1KmJ24HczsG2jKhCSn2vFY2lEEuazBQ4VQwk=; b=cpwXroKR21no5E5LSadCU5ppKn2G3bm59LneREb+gn6aYCXAO+Qv+nIUYILQJy3USh ZEKZxhT+G3EgPvwleo8WjK1AKTm89lpC3h6BstDU1m8eIgT3p5EBdhQ20UaPvPWoFRMd jvhyLwPXSHRIJ7v4kEsJrdWrrFAnXCdltIzCm3Onu7X85G+gX685LjXwxR54m/Pbi3aa /xy+sYwqHC7/bQT/Q3FfF/WOIGqVtc33db8JXlEaGyOmR/wIXaE31zzwcjTN5yHsjNc/ tI11gmLgUqzUHPWvac5Lvl0+y6tdhD6f3rT636X5zkHVE8K0CKFsZDKClrZ7ko+HD/OO gnoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=exla7Pi1KmJ24HczsG2jKhCSn2vFY2lEEuazBQ4VQwk=; b=e/JqdSfwclNmh3NrA/kOK16jvwy7xNnG5Z8RaakBDLlMdCs4V+EUVuDPWnyg2GvWbd NENA1KEmdpZ9OXd1FC9bZcaMnSirBzpoB7WbOsOOw/vVnXfirKgnJh0ECZqQLZhdqahS WjBIS50rGyIcizYym9ssOcn8OrI5BrnSHd1L6tsScvv73Vyc3djRvC06uXIbV92PVp+g RAdO9grjPVQoZJ7X7IZD8FNt9rabMHhl80vE+2SBiCmgPZyus3uqhewhS1cG/fHG2L1F X7rnWXIBDjExxq/cC/lo3dpoASy64rWwgRgvhd0pHCWdwd/W9XTg4FTrarb9tXIP8p53 N6Fg== X-Gm-Message-State: APjAAAUELx3xSijzPdl+OzEE89lSwjQGTgpyST16J1HWhsZRqaZ/varn fy/coXR5OBBHBQ4N7zc8zr0udKim8+M= X-Google-Smtp-Source: APXvYqweVzXnwMh+jkM3qi0XzgD//XQVG7jmFmWz3tpjM7DK+8aiV1DgEOXS0PomA6kxNHfYMvrDXg== X-Received: by 2002:a7b:c5d8:: with SMTP id n24mr4633927wmk.50.1579614520026; Tue, 21 Jan 2020 05:48:40 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v14sm52140308wrm.28.2020.01.21.05.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 05:48:39 -0800 (PST) Date: Tue, 21 Jan 2020 14:48:38 +0100 From: Robin Jarry To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20200121134838.dyfytargze3n2gvd@6wind.com> References: <20200120173725.57529-1-bruce.richardson@intel.com> <20200121111228.5591-1-bruce.richardson@intel.com> <20200121132238.zukav3ysrl3ijpor@6wind.com> <20200121133737.GE1747@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200121133737.GE1747@bricha3-MOBL.ger.corp.intel.com> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH v2] build: allow using wildcards to disable drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2020-01-21, Bruce Richardson: > > > +from glob import iglob # glob iterator > > > > No need to make it explicit. People can read the description in the > > official docs. > > Except the fact that you yourself mistook it for a case-insensitive glob > implies that a comment is needed! :-) The fact that I should check things before I make comments should not force people to add comments next to imports :-) > This is script is to be called from the build system. I'm not worried about > incorrect numbers of args, and argparse itself seems overkill. I'll add a > check to print an error if len(argv) != 1. Fair enough. However, argparse is never overkill. Using it is not going to slow down your script. > Just keeping the code short. I actually had originally got the print join > in the same line as the list comprehension but that even I felt was a bit > unreadable - even if it did leave a nice short script! This is not perl^Wa competition :-) -- Robin