From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F20FA0525; Wed, 22 Jan 2020 09:08:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CC972B98; Wed, 22 Jan 2020 09:08:46 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 06F0BF04; Wed, 22 Jan 2020 09:08:44 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 00:08:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,348,1574150400"; d="scan'208";a="275540700" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by FMSMGA003.fm.intel.com with ESMTP; 22 Jan 2020 00:08:40 -0800 Date: Wed, 22 Jan 2020 16:08:15 +0800 From: Ye Xiaolong To: Beilei Xing Cc: dev@dpdk.org, qi.z.zhang@intel.com, yahui.cao@intel.com, stable@dpdk.org Message-ID: <20200122080815.GD41361@intel.com> References: <1579522734-16566-1-git-send-email-beilei.xing@intel.com> <1579606931-77414-1-git-send-email-beilei.xing@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1579606931-77414-1-git-send-email-beilei.xing@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix FDIR flag issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/21, Beilei Xing wrote: >If there's no mark action when creating a FDIR rule, >there shouldn't be FDIR flags in mbuf. > >Fixes: f5cafa961fae ("net/ice: add flow director create and destroy") >Fixes: bd984f155f49 ("net/ice/base: support FDIR") >Cc: stable@dpdk.org > >Signed-off-by: Beilei Xing >Acked-by: Qi Zhang >--- > >V2 change: > - Code refine. > > drivers/net/ice/base/ice_fdir.c | 2 +- > drivers/net/ice/base/ice_fdir.h | 1 + > drivers/net/ice/ice_fdir_filter.c | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c >index 87fa0af..20d64f8 100644 >--- a/drivers/net/ice/base/ice_fdir.c >+++ b/drivers/net/ice/base/ice_fdir.c >@@ -418,7 +418,7 @@ ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *input, > fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET; > fdir_fltr_ctx.comp_q = ICE_FXD_FLTR_QW0_COMP_Q_ZERO; > fdir_fltr_ctx.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW; >- fdir_fltr_ctx.fdid_prio = 3; >+ fdir_fltr_ctx.fdid_prio = input->fdid_prio; > fdir_fltr_ctx.desc_prof = 1; > fdir_fltr_ctx.desc_prof_prio = 3; > ice_set_fd_desc_val(&fdir_fltr_ctx, fdesc); >diff --git a/drivers/net/ice/base/ice_fdir.h b/drivers/net/ice/base/ice_fdir.h >index db1f835..c811f76 100644 >--- a/drivers/net/ice/base/ice_fdir.h >+++ b/drivers/net/ice/base/ice_fdir.h >@@ -202,6 +202,7 @@ struct ice_fdir_fltr { > u8 cnt_ena; > u8 fltr_status; > u16 cnt_index; >+ u8 fdid_prio; > u32 fltr_id; > }; > >diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c >index fa87074..42b9628 100644 >--- a/drivers/net/ice/ice_fdir_filter.c >+++ b/drivers/net/ice/ice_fdir_filter.c >@@ -1504,6 +1504,7 @@ ice_fdir_parse_action(struct ice_adapter *ad, > > mark_spec = actions->conf; > filter->input.fltr_id = mark_spec->id; >+ filter->input.fdid_prio = ICE_FXD_FLTR_QW1_FDID_PRI_ONE; > break; > case RTE_FLOW_ACTION_TYPE_COUNT: > counter_num++; >-- >2.7.4 > Applied to dpdk-next-net-intel, Thanks.