DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2 0/1] test/crypto: remove repeated test and enable on QAT
@ 2020-01-22 14:42 Adam Dybkowski
  2020-01-22 14:42 ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
  0 siblings, 1 reply; 4+ messages in thread
From: Adam Dybkowski @ 2020-01-22 14:42 UTC (permalink / raw)
  To: dev, fiona.trahe, akhil.goyal; +Cc: Adam Dybkowski

Remove one AES GCM scatter-gather unit test repetition
and enable this test on QAT (after a fix included in the commit
b26ef1a11f21).

---
v2:
* Repair referenced commit id.

Adam Dybkowski (1):
  test/crypto: remove repeated test and enable on QAT

 app/test/test_cryptodev.c | 7 -------
 1 file changed, 7 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT
  2020-01-22 14:42 [dpdk-dev] [PATCH v2 0/1] test/crypto: remove repeated test and enable on QAT Adam Dybkowski
@ 2020-01-22 14:42 ` Adam Dybkowski
  2020-01-22 14:48   ` Trahe, Fiona
  0 siblings, 1 reply; 4+ messages in thread
From: Adam Dybkowski @ 2020-01-22 14:42 UTC (permalink / raw)
  To: dev, fiona.trahe, akhil.goyal; +Cc: Adam Dybkowski

Remove one AES GCM scatter-gather unit test repetition
and enable this test on QAT (after a fix included in the commit
b26ef1a11f21).

Fixes: 157d0b11d204 ("test/crypto: add capability checks")
Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check")

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 app/test/test_cryptodev.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 749c3c1b2..12c113848 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -11158,11 +11158,6 @@ test_AES_GCM_auth_encrypt_SGL_out_of_place_1500B_2000B(void)
 static int
 test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_1seg(void)
 {
-	/* This test is not for QAT PMD */
-	if (gbl_driver_id == rte_cryptodev_driver_id_get(
-			RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)))
-		return -ENOTSUP;
-
 	return test_authenticated_encryption_SGL(
 			&gcm_test_case_8, OUT_OF_PLACE, 400,
 			gcm_test_case_8.plaintext.len);
@@ -11617,8 +11612,6 @@ static struct unit_test_suite cryptodev_testsuite  = {
 		/** AES GCM Authenticated Encryption */
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_AES_GCM_auth_encrypt_SGL_in_place_1500B),
-		TEST_CASE_ST(ut_setup, ut_teardown,
-			test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_1seg),
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_400B),
 		TEST_CASE_ST(ut_setup, ut_teardown,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT
  2020-01-22 14:42 ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
@ 2020-01-22 14:48   ` Trahe, Fiona
  2020-01-28  6:18     ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Trahe, Fiona @ 2020-01-22 14:48 UTC (permalink / raw)
  To: Dybkowski, AdamX, dev, akhil.goyal; +Cc: Trahe, Fiona



> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Wednesday, January 22, 2020 2:42 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT
> 
> Remove one AES GCM scatter-gather unit test repetition
> and enable this test on QAT (after a fix included in the commit
> b26ef1a11f21).
> 
> Fixes: 157d0b11d204 ("test/crypto: add capability checks")
> Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check")
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT
  2020-01-22 14:48   ` Trahe, Fiona
@ 2020-01-28  6:18     ` Akhil Goyal
  0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2020-01-28  6:18 UTC (permalink / raw)
  To: Trahe, Fiona, Dybkowski, AdamX, dev

> >
> > Remove one AES GCM scatter-gather unit test repetition
> > and enable this test on QAT (after a fix included in the commit
> > b26ef1a11f21).
> >
> > Fixes: 157d0b11d204 ("test/crypto: add capability checks")
> > Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check")
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Squashed to original commit as they were not applied to Master

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-28  6:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 14:42 [dpdk-dev] [PATCH v2 0/1] test/crypto: remove repeated test and enable on QAT Adam Dybkowski
2020-01-22 14:42 ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
2020-01-22 14:48   ` Trahe, Fiona
2020-01-28  6:18     ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git