DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, jerinj@marvell.com
Subject: [dpdk-dev] [PATCH 1/2] net/octeontx2: check compiler flag before use
Date: Fri, 24 Jan 2020 15:37:54 +0000	[thread overview]
Message-ID: <20200124153755.13939-2-bruce.richardson@intel.com> (raw)
In-Reply-To: <20200124153755.13939-1-bruce.richardson@intel.com>

Rather than assuming all compilers support the -flax-vector-extensions
flag, we should test this before using it, thereby potentially avoiding
warnings.

Cc: jerinj@marvell.com

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/octeontx2/meson.build | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build
index fad3076a3..bde19678f 100644
--- a/drivers/net/octeontx2/meson.build
+++ b/drivers/net/octeontx2/meson.build
@@ -26,9 +26,7 @@ sources = files('otx2_rx.c',
 
 deps += ['bus_pci', 'common_octeontx2', 'mempool_octeontx2']
 
-cflags += ['-flax-vector-conversions']
-
-extra_flags = []
+extra_flags = ['-flax-vector-conversions']
 # This integrated controller runs only on a arm64 machine, remove 32bit warnings
 if not dpdk_conf.get('RTE_ARCH_64')
 	extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-- 
2.20.1


  reply	other threads:[~2020-01-24 15:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24 15:37 [dpdk-dev] [PATCH 0/2] remove compiler warnings with icc using meson Bruce Richardson
2020-01-24 15:37 ` Bruce Richardson [this message]
2020-01-28 16:55   ` [dpdk-dev] [PATCH 1/2] net/octeontx2: check compiler flag before use Jerin Jacob
2020-01-24 15:37 ` [dpdk-dev] [PATCH 2/2] build: remove warnings for builds with icc Bruce Richardson
2020-01-24 15:51   ` Burakov, Anatoly
2020-01-24 16:34     ` Bruce Richardson
2020-02-06  2:23 ` [dpdk-dev] [PATCH 0/2] remove compiler warnings with icc using meson Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200124153755.13939-2-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).