From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3373AA0533; Fri, 24 Jan 2020 17:34:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BDED3576; Fri, 24 Jan 2020 17:34:48 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AC19034F3 for ; Fri, 24 Jan 2020 17:34:46 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 08:34:45 -0800 X-IronPort-AV: E=Sophos;i="5.70,358,1574150400"; d="scan'208";a="221064853" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.97]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Jan 2020 08:34:44 -0800 Date: Fri, 24 Jan 2020 16:34:41 +0000 From: Bruce Richardson To: "Burakov, Anatoly" Cc: dev@dpdk.org Message-ID: <20200124163441.GA1691@bricha3-MOBL.ger.corp.intel.com> References: <20200124153755.13939-1-bruce.richardson@intel.com> <20200124153755.13939-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH 2/2] build: remove warnings for builds with icc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 24, 2020 at 03:51:16PM +0000, Burakov, Anatoly wrote: > On 24-Jan-20 3:37 PM, Bruce Richardson wrote: > > While icc builds without the "werror" setting build successfully, there are > > a lot of warnings. To make the output cleaner, and to allow building with > > warnings enabled, we can add a list of warning ids to ignore. > > > > Signed-off-by: Bruce Richardson > > --- > > config/meson.build | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/config/meson.build b/config/meson.build > > index 28a57f56f..6c46767e3 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -197,6 +197,12 @@ if not dpdk_conf.get('RTE_ARCH_64') > > # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!! > > warning_flags += '-Wno-pointer-to-int-cast' > > endif > > +if cc.get_id() == 'intel' > > + warning_ids = [188, 2203, 2279, 2557, 3179, 3656] > > Maybe worth it to add short warning descriptions in comments? e.g. > > # 188: unused blah > # 2203: wrong foo > Yeah, I started doing it that way, but then I decided that it was making the block rather long and that the extra benefit it would give is quite small. But if people think it's worthwhile, I can rework to do so. /Bruce