DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/pdump: fix build with clang
@ 2020-01-26  1:04 Stephen Hemminger
  2020-02-06  2:31 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2020-01-26  1:04 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, reshma.pattan, stable

Clang checks indentation and found incorrect indentation in pdump.

app/pdump/main.c:598:3: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]

Cc: reshma.pattan@intel.com
Cc: stable@dpdk.org
Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/pdump/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 903d02f48233..d05a0236670a 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -595,7 +595,7 @@ configure_vdev(uint16_t port_id)
 	if (ret != 0)
 		rte_exit(EXIT_FAILURE, "dev config failed\n");
 
-	 for (q = 0; q < txRings; q++) {
+	for (q = 0; q < txRings; q++) {
 		ret = rte_eth_tx_queue_setup(port_id, q, TX_DESC_PER_QUEUE,
 				rte_eth_dev_socket_id(port_id), NULL);
 		if (ret < 0)
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/pdump: fix build with clang
  2020-01-26  1:04 [dpdk-dev] [PATCH] app/pdump: fix build with clang Stephen Hemminger
@ 2020-02-06  2:31 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-02-06  2:31 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, stable, reshma.pattan

26/01/2020 02:04, Stephen Hemminger:
> Clang checks indentation and found incorrect indentation in pdump.
> 
> app/pdump/main.c:598:3: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
> 
> Cc: reshma.pattan@intel.com
> Cc: stable@dpdk.org
> Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-06  2:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-26  1:04 [dpdk-dev] [PATCH] app/pdump: fix build with clang Stephen Hemminger
2020-02-06  2:31 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git