From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: yahui.cao@intel.com, beilei.xing@intel.com,
chenmin.sun@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix fdir GTP-U pattern
Date: Sun, 26 Jan 2020 17:04:58 +0800 [thread overview]
Message-ID: <20200126090458.GA49698@intel.com> (raw)
In-Reply-To: <20200121013048.8640-1-qi.z.zhang@intel.com>
On 01/21, Qi Zhang wrote:
>Base on current fdir implementation for GTP-U, inner specification is
>not supported, issue a rule for eth/ipv4/gtpu/ipv4 will also match
>eth/ipv4/gtpu/ipv6, the patch add new pattern list to align with exist
>implementation.
>
>Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
>Cc: stable@dpdk.org
>
>Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>---
>
>v2:
>- rename ICE_FDIR_INSET_GTPU_IPV4 to ICE_FDIR_INSET_GTPU
>- rename ICE_FDIR_INSET_GTPU_EH_IPV4 to ICE_FDIR_INSET_GTPU_EH
>
> drivers/net/ice/ice_fdir_filter.c | 9 ++++-----
> drivers/net/ice/ice_generic_flow.c | 15 +++++++++++++++
> drivers/net/ice/ice_generic_flow.h | 2 ++
> 3 files changed, 21 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
>index 4c5ddfbdb..8a7212675 100644
>--- a/drivers/net/ice/ice_fdir_filter.c
>+++ b/drivers/net/ice/ice_fdir_filter.c
>@@ -67,10 +67,10 @@
> ICE_FDIR_INSET_VXLAN_IPV4 | \
> ICE_INSET_TUN_SCTP_SRC_PORT | ICE_INSET_TUN_SCTP_DST_PORT)
>
>-#define ICE_FDIR_INSET_GTPU_IPV4 (\
>+#define ICE_FDIR_INSET_GTPU (\
> ICE_INSET_GTPU_TEID)
>
>-#define ICE_FDIR_INSET_GTPU_EH_IPV4 (\
>+#define ICE_FDIR_INSET_GTPU_EH (\
> ICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)
>
> static struct ice_pattern_match_item ice_fdir_pattern_os[] = {
>@@ -125,9 +125,8 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
> ICE_FDIR_INSET_VXLAN_IPV4_TCP, ICE_INSET_NONE},
> {pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
> ICE_FDIR_INSET_VXLAN_IPV4_SCTP, ICE_INSET_NONE},
>- {pattern_eth_ipv4_gtpu_ipv4, ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
>- {pattern_eth_ipv4_gtpu_eh_ipv4,
>- ICE_FDIR_INSET_GTPU_EH_IPV4, ICE_INSET_NONE},
>+ {pattern_eth_ipv4_gtpu, ICE_FDIR_INSET_GTPU, ICE_INSET_NONE},
>+ {pattern_eth_ipv4_gtpu_eh, ICE_FDIR_INSET_GTPU_EH, ICE_INSET_NONE},
> };
>
> static struct ice_flow_parser ice_fdir_parser_os;
>diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
>index c9efa8356..38ac799d8 100644
>--- a/drivers/net/ice/ice_generic_flow.c
>+++ b/drivers/net/ice/ice_generic_flow.c
>@@ -1034,6 +1034,13 @@ enum rte_flow_item_type pattern_eth_ipv6_nvgre_eth_ipv6_icmp6[] = {
> };
>
> /* GTPU */
>+enum rte_flow_item_type pattern_eth_ipv4_gtpu[] = {
>+ RTE_FLOW_ITEM_TYPE_ETH,
>+ RTE_FLOW_ITEM_TYPE_IPV4,
>+ RTE_FLOW_ITEM_TYPE_UDP,
>+ RTE_FLOW_ITEM_TYPE_GTPU,
>+ RTE_FLOW_ITEM_TYPE_END,
>+};
> enum rte_flow_item_type pattern_eth_ipv4_gtpu_ipv4[] = {
> RTE_FLOW_ITEM_TYPE_ETH,
> RTE_FLOW_ITEM_TYPE_IPV4,
>@@ -1042,6 +1049,14 @@ enum rte_flow_item_type pattern_eth_ipv4_gtpu_ipv4[] = {
> RTE_FLOW_ITEM_TYPE_IPV4,
> RTE_FLOW_ITEM_TYPE_END,
> };
>+enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh[] = {
>+ RTE_FLOW_ITEM_TYPE_ETH,
>+ RTE_FLOW_ITEM_TYPE_IPV4,
>+ RTE_FLOW_ITEM_TYPE_UDP,
>+ RTE_FLOW_ITEM_TYPE_GTPU,
>+ RTE_FLOW_ITEM_TYPE_GTP_PSC,
>+ RTE_FLOW_ITEM_TYPE_END,
>+};
> enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh_ipv4[] = {
> RTE_FLOW_ITEM_TYPE_ETH,
> RTE_FLOW_ITEM_TYPE_IPV4,
>diff --git a/drivers/net/ice/ice_generic_flow.h b/drivers/net/ice/ice_generic_flow.h
>index ac085b47f..adc30ee2a 100644
>--- a/drivers/net/ice/ice_generic_flow.h
>+++ b/drivers/net/ice/ice_generic_flow.h
>@@ -336,7 +336,9 @@ extern enum rte_flow_item_type pattern_eth_ipv6_nvgre_eth_ipv6_sctp[];
> extern enum rte_flow_item_type pattern_eth_ipv6_nvgre_eth_ipv6_icmp6[];
>
> /* GTPU */
>+extern enum rte_flow_item_type pattern_eth_ipv4_gtpu[];
> extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_ipv4[];
>+extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh[];
> extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh_ipv4[];
> extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh_ipv4_udp[];
> extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh_ipv4_tcp[];
>--
>2.13.6
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
prev parent reply other threads:[~2020-01-26 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 1:30 Qi Zhang
2020-01-26 9:04 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126090458.GA49698@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=chenmin.sun@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=yahui.cao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).