From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3D7BA04B3; Mon, 27 Jan 2020 22:08:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CD671BFD1; Mon, 27 Jan 2020 22:08:11 +0100 (CET) Received: from mails2n0-route0.email.arizona.edu (mails2n0-route0.email.arizona.edu [128.196.130.122]) by dpdk.org (Postfix) with ESMTP id 0D2A71BFB6 for ; Mon, 27 Jan 2020 22:08:08 +0100 (CET) IronPort-SDR: qd/QbyCCcCPhw2bSlvGlI8Nn/fMaia+NtUdihx8G5fEMUKwas1SSne9SkeORDc8Q23hSHIo5T0 nxUiCJfbnGRA== IronPort-PHdr: =?us-ascii?q?9a23=3A7CO1MRKO0hN7ca2J0dmcpTZWNBhigK39O0sv0r?= =?us-ascii?q?FitYgXKv3zrarrMEGX3/hxlliBBdydt6sYzbGM+Pm8ACRAuc/H7ClZNsQUFl?= =?us-ascii?q?cssoY/p0QYGsmLCEn2frbBThcRO4B8bmJj5GyxKkNPGczzNBX4q3y26iMOSF?= =?us-ascii?q?2kbVImbuv6FZTPgMupyuu854PcYxlShDq6fLh+MAi6oR/eu8ULjoZuMKg8xg?= =?us-ascii?q?XGrndVdOla2H5jKVaPkxrh/Mu984Nv/ipKt/4968JMVLjxcrglQ7BfEDkoKX?= =?us-ascii?q?0+6tfxtRnEQwuP538cXXsTnxFVHQXL7wz0U4novCfiueVzxCeVPcvtTbApQj?= =?us-ascii?q?ui9LtkSAXpiCgcKTE09nzch9Fqg6JapBKhoAF/w5LRbYqIOvdyYr/RcNUHTm?= =?us-ascii?q?daQM1fSzJODZ+9b4sXDuoOI+BYr5Xmp1ATqReyHBSgCP/zxjNNgHL52rE03e?= =?us-ascii?q?Q/HA3fxQAuHc8BsG7NoNvoKacSSvi1w7fUwjXfdv9W3TD96YbVeRwlofyAWL?= =?us-ascii?q?R9fs3Nx0cvCQ7Jl0ycp474MDOPz+gDrnWb7/F4Ve2xl2Entxx6rjyxysswj4?= =?us-ascii?q?XEgJ8exFLZ+iVj2Is7JcO2SFJ1Yd6qHpVeqjqXO5dqTs8+X21kpDo2xqEAtJ?= =?us-ascii?q?WmfCYK0pMnxxvHZvKDboiI5B3iVOeLLjd/mXlrZbK/hxev+kWnxe38V9W03U?= =?us-ascii?q?1PriVfk9nMsm0B2wbT68iAV/t95Fyh2SuJ1wDV6uBIO1w7la3eK5M4xLM7i5?= =?us-ascii?q?kdsVzbEyPrnEj6krWaelg69uSy6unqZq/qq5+EO4NpjgzyLL4iltGhDegiMw?= =?us-ascii?q?UDW3KX9fm/2bDi+0DyXa9EgecskqbDtZDXPcEbpqmkDABLyosj8BO/Dyu+0N?= =?us-ascii?q?QfgHkHMEpJeBKZgIjtPFHDOPf4De+jg1StlTdk3erKMaH6ApnXNHfDirbhfL?= =?us-ascii?q?d6605a0gU/185Q6I9JCr0ZIfLzXFH+tMDAAxMkNwG43fzrBMhj2o8EWG+CBr?= =?us-ascii?q?WVPaPKvV+N/O0vIu2MZIEPuDb6Lvgo/+XujX84mV8fYKmp25QWaHGiEfRhOE?= =?us-ascii?q?iWfWHsjs0bHmcQvwo/TevqiFuYXjJJeXm9Qr886ikhCI26FYfDWpytgLuZ0S?= =?us-ascii?q?egA51WYGZGC1CIEXjycYWLRvcMZTmdIs9kiDMEVLyhR5U92hGpsQ/w06BnIf?= =?us-ascii?q?bM+i0EqZLj08B46PfQlREy9Dx0C96R026KT2B0hGwIQyQ73KZwoExl0FuMza?= =?us-ascii?q?94g/lAH9xJ+/xJShs6NYLbz+FiFt/9RBzBc8yUR1a+X9qmAis9TtUrw98BMA?= =?us-ascii?q?5BHID2gh3d9yayD7xTkKaEUs8a6KXZilrsIdZ8wnGO76kgxw0pQ9dnMGSngv?= =?us-ascii?q?c55g/OHZXUlUOI0a2tcPJPj2b26G6fwD/W7wljWwlqXPCAAi0S?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AZAADaUC9ejAVFDMBmHAEBAQEBBwE?= =?us-ascii?q?BEQEEBAEBgWcHAQELAYNqMSqMN2CGJ1UGiyaKJYUpggQBAQEMAQETGQECAQG?= =?us-ascii?q?GZiQ0CQ4CAw0BAQEEAQEBAQEFAgIBEwEBASaFOwYygjspgnsGJ1IQAgEaDyU?= =?us-ascii?q?POg4CBA4FgyaCVyWuFTOKQYE4AYpagUMaeYEHgRGDURyEeoUhBJd6l16CQ5Z?= =?us-ascii?q?SmnsBLalAAgQGBQIUAYFSOIFZMxoIGxWDJ1AYDY1ThiQBFxWODSEhATKBBgE?= =?us-ascii?q?BjQQBAQ?= X-IPAS-Result: =?us-ascii?q?A2AZAADaUC9ejAVFDMBmHAEBAQEBBwEBEQEEBAEBgWcHA?= =?us-ascii?q?QELAYNqMSqMN2CGJ1UGiyaKJYUpggQBAQEMAQETGQECAQGGZiQ0CQ4CAw0BA?= =?us-ascii?q?QEEAQEBAQEFAgIBEwEBASaFOwYygjspgnsGJ1IQAgEaDyUPOg4CBA4FgyaCV?= =?us-ascii?q?yWuFTOKQYE4AYpagUMaeYEHgRGDURyEeoUhBJd6l16CQ5ZSmnsBLalAAgQGB?= =?us-ascii?q?QIUAYFSOIFZMxoIGxWDJ1AYDY1ThiQBFxWODSEhATKBBgEBjQQBAQ?= X-IronPort-AV: E=Sophos;i="5.70,371,1574146800"; d="scan'208";a="452293550" Received: from optima.cs.arizona.edu ([192.12.69.5]) by mails2n0out.email.arizona.edu with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2020 14:08:03 -0700 Received: from lectura.cs.arizona.edu (lectura.cs.arizona.edu [192.12.69.186]) by optima.cs.arizona.edu (8.14.4/8.14.4/Debian-2ubuntu2.1) with ESMTP id 00RL833x005416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jan 2020 14:08:03 -0700 Received: from lectura.cs.arizona.edu (localhost [127.0.0.1]) by lectura.cs.arizona.edu (8.14.4/8.14.4/Debian-4.1ubuntu1.1) with ESMTP id 00RL83Ph004623; Mon, 27 Jan 2020 14:08:03 -0700 Received: (from shijunxiao@localhost) by lectura.cs.arizona.edu (8.14.4/8.14.4/Submit) id 00RL832Y004622; Mon, 27 Jan 2020 14:08:03 -0700 Message-Id: <202001272108.00RL832Y004622@lectura.cs.arizona.edu> From: Junxiao Shi To: CC: Akhil Goyal Thread-Topic: [dpdk-dev] [PATCH] cryptodev: fix set_sym_session_private_data error in sessionless mode Thread-Index: AQHVr4DiggUhwqB5WkOi6Uu6f2cjxaf+sLaw References: <201912101740.xBAHe5l2002645@lectura.cs.arizona.edu> References: Date: Mon, 27 Jan 2020 11:32:11 -0700 Subject: [dpdk-dev] [PATCH] drivers/crypto: fix set_sym_session_private_data error in sessionless mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When OpenSSL or AESNI-MB cryptodev is being used in sessionless mode for symmetric crypto operation (e.g. SHA256 hash), the driver prints error message: CRYPTODEV: set_sym_session_private_data() line 489: Set private data for driver 0 not allowed Then, AESNI-MB driver segfaults in post_process_mb_job(). Bugzilla ID: 377 Fixes: b3bbd9e ("cryptodev: support device independent sessions") Fixes: c68d7aa ("crypto/aesni_mb: use architecture independent macros") Signed-off-by: Junxiao Shi --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ++-- drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c index 97d9f81..33f4167 100644 --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c @@ -729,10 +729,10 @@ get_session(struct aesni_mb_qp *qp, struct rte_crypto_op *op) op->sym->session, cryptodev_driver_id); } else { - void *_sess = NULL; + void *_sess = rte_cryptodev_sym_session_create(qp->sess_mp); void *_sess_private_data = NULL; - if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) + if (_sess == NULL) return NULL; if (rte_mempool_get(qp->sess_mp_priv, diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index 91f0283..199097b 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -762,10 +762,10 @@ get_session(struct openssl_qp *qp, struct rte_crypto_op *op) return NULL; /* provide internal session */ - void *_sess = NULL; + void *_sess = rte_cryptodev_sym_session_create(qp->sess_mp); void *_sess_private_data = NULL; - if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) + if (_sess == NULL) return NULL; if (rte_mempool_get(qp->sess_mp_priv, -- 2.7.4