DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Junxiao Shi <git@mail1.yoursunny.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bpf: properly install headers in meson build
Date: Tue, 28 Jan 2020 13:51:00 +0000	[thread overview]
Message-ID: <20200128135100.GA356@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <202001272140.00RLeVmL031759@lectura.cs.arizona.edu>

On Mon, Jan 27, 2020 at 02:38:00PM -0700, Junxiao Shi wrote:
> Previously, when librte_bpf is built with meson+ninja, its
> headers such as bpf_def is not installed to the system.
> This commit fixes this problem.
> 
> Fixes: 94972f3 ("bpf: add BPF loading and execution framework")
> 
> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> ---
>  lib/librte_bpf/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build
> index 13fc02d..52cfaf9 100644
> --- a/lib/librte_bpf/meson.build
> +++ b/lib/librte_bpf/meson.build
> @@ -14,7 +14,7 @@ elif dpdk_conf.has('RTE_ARCH_ARM64')
>  	sources += files('bpf_jit_arm64.c')
>  endif
>  
> -install_headers = files('bpf_def.h',
> +install_headers('bpf_def.h',
>  			'rte_bpf.h',
>  			'rte_bpf_ethdev.h')
>  
Yes, good catch.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2020-01-28 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 21:38 Junxiao Shi
2020-01-28 13:51 ` Bruce Richardson [this message]
2020-02-06  2:29   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200128135100.GA356@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=git@mail1.yoursunny.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).