DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] bpf: properly install headers in meson build
@ 2020-01-27 21:38 Junxiao Shi
  2020-01-28 13:51 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Junxiao Shi @ 2020-01-27 21:38 UTC (permalink / raw)
  To: dev

Previously, when librte_bpf is built with meson+ninja, its
headers such as bpf_def is not installed to the system.
This commit fixes this problem.

Fixes: 94972f3 ("bpf: add BPF loading and execution framework")

Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
---
 lib/librte_bpf/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build
index 13fc02d..52cfaf9 100644
--- a/lib/librte_bpf/meson.build
+++ b/lib/librte_bpf/meson.build
@@ -14,7 +14,7 @@ elif dpdk_conf.has('RTE_ARCH_ARM64')
 	sources += files('bpf_jit_arm64.c')
 endif
 
-install_headers = files('bpf_def.h',
+install_headers('bpf_def.h',
 			'rte_bpf.h',
 			'rte_bpf_ethdev.h')
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] bpf: properly install headers in meson build
  2020-01-27 21:38 [dpdk-dev] [PATCH] bpf: properly install headers in meson build Junxiao Shi
@ 2020-01-28 13:51 ` Bruce Richardson
  2020-02-06  2:29   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-01-28 13:51 UTC (permalink / raw)
  To: Junxiao Shi; +Cc: dev

On Mon, Jan 27, 2020 at 02:38:00PM -0700, Junxiao Shi wrote:
> Previously, when librte_bpf is built with meson+ninja, its
> headers such as bpf_def is not installed to the system.
> This commit fixes this problem.
> 
> Fixes: 94972f3 ("bpf: add BPF loading and execution framework")
> 
> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> ---
>  lib/librte_bpf/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build
> index 13fc02d..52cfaf9 100644
> --- a/lib/librte_bpf/meson.build
> +++ b/lib/librte_bpf/meson.build
> @@ -14,7 +14,7 @@ elif dpdk_conf.has('RTE_ARCH_ARM64')
>  	sources += files('bpf_jit_arm64.c')
>  endif
>  
> -install_headers = files('bpf_def.h',
> +install_headers('bpf_def.h',
>  			'rte_bpf.h',
>  			'rte_bpf_ethdev.h')
>  
Yes, good catch.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] bpf: properly install headers in meson build
  2020-01-28 13:51 ` Bruce Richardson
@ 2020-02-06  2:29   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-02-06  2:29 UTC (permalink / raw)
  To: Junxiao Shi; +Cc: dev, Bruce Richardson

28/01/2020 14:51, Bruce Richardson:
> On Mon, Jan 27, 2020 at 02:38:00PM -0700, Junxiao Shi wrote:
> > Previously, when librte_bpf is built with meson+ninja, its
> > headers such as bpf_def is not installed to the system.
> > This commit fixes this problem.
> > 
> > Fixes: 94972f3 ("bpf: add BPF loading and execution framework")
> > 
> > Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> > ---
> > -install_headers = files('bpf_def.h',
> > +install_headers('bpf_def.h',
> >  			'rte_bpf.h',
> >  			'rte_bpf_ethdev.h')
> >  
> Yes, good catch.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-06  2:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 21:38 [dpdk-dev] [PATCH] bpf: properly install headers in meson build Junxiao Shi
2020-01-28 13:51 ` Bruce Richardson
2020-02-06  2:29   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git