From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2F2DFA04FA;
Sun, 2 Feb 2020 11:38:28 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 7C7EB1BF78;
Sun, 2 Feb 2020 11:38:27 +0100 (CET)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
[209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 95BDC1BEE5
for <dev@dpdk.org>; Sun, 2 Feb 2020 11:38:25 +0100 (CET)
Received: by mail-wm1-f66.google.com with SMTP id c84so13671263wme.4
for <dev@dpdk.org>; Sun, 02 Feb 2020 02:38:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=3G9/deofhHFKOdCPBZPy3BydSSrTVVML+Q718Ne8otU=;
b=cKGk5QMLcNlOY49dRJF2qt9+y/OqVP7ezz9PC5fLd/eEeLsiVaeZ1tPY2EeRjU+ZWf
QZLIU3g1Z1aSZf7qwAZVRPedwmR84GtrH6IzIsPKdLMxvFLYp9ZA+85XxYY+RtWvsu0j
DU+qpQggIDARaxrzDizqVC6fyDy15iqKBg1iQl/YH8xlMaIhB8sXIhL7gqN7Rk/+ckPR
53ezSIXZeEP8tL2N6r2fAqds2g87fvzb8rR5gaN1FcZdo2lXedyCz79rP+ep7XwY+iM4
py3I1PioiSq2AyJcbPDcbgJwLSHlzpka/CMAnMb7JJ776PV1P3xq6+rOWkH8yK2PeTjl
Fnpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=3G9/deofhHFKOdCPBZPy3BydSSrTVVML+Q718Ne8otU=;
b=kv1gKd9JrQlhpxUxXgX+D1p8nzQXmFHzVxv/r7eW6YTO8jdBXBtyT3ZqrXCCugBP/G
kaek2E90jE3ACfazSZXbYnT+ME+hymyCiK1SJVNingLyyp6RdCDfp7svoe/COPcv9/o2
EmvfSE74BAJBZ3ap5zXJNji1SJXqP0lw7aGLGPRpEzyUFghblWN+vTMrzomq+F6E12K8
oq5jMpYOzEtDAN9mpQBJqZ9GhRV8gADiUY9q0o20/1DW8WwaK/Gg6JsJJQAWFBOi/0Rr
muxf4f99F5INsChVyyIwUwoYC9RQahTG3/x5vCEg04TZ3a9ZNu5EdcoT5/dbXnatVrhr
E2Dg==
X-Gm-Message-State: APjAAAUrCiZk4XOwaXKGQbSQQxuZLKG/3W+BKIoLsVV+rEVCFRIoSIaw
FGHyHRTbb08WRNSnUwO+ljbrx0uJtXt02A==
X-Google-Smtp-Source: APXvYqzWvrY6augrVzalLykliQgtcyEWBW1XGZPtbLC1GQUtl6bRo/rFQruzl84R3K1I0JEinJiGPQ==
X-Received: by 2002:a1c:1d1:: with SMTP id 200mr23772702wmb.181.1580639905230;
Sun, 02 Feb 2020 02:38:25 -0800 (PST)
Received: from shemminger-XPS-13-9360
([2001:67c:1810:f051:c492:1a1f:b276:cd6e])
by smtp.gmail.com with ESMTPSA id x10sm19945203wrv.60.2020.02.02.02.38.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 02 Feb 2020 02:38:25 -0800 (PST)
Date: Sun, 2 Feb 2020 02:38:17 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: <jerinj@marvell.com>
Cc: <dev@dpdk.org>, <pkapoor@marvell.com>, <ndabilpuram@marvell.com>,
<kirankumark@marvell.com>, <pbhagavatula@marvell.com>,
<pathreya@marvell.com>, <nsaxena@marvell.com>, <sshankarnara@marvell.com>,
<honnappa.nagarahalli@arm.com>, <thomas@monjalon.net>,
<david.marchand@redhat.com>, <ferruh.yigit@intel.com>,
<arybchenko@solarflare.com>, <ajit.khaparde@broadcom.com>,
<xiaolong.ye@intel.com>, <rasland@mellanox.com>,
<maxime.coquelin@redhat.com>, <akhil.goyal@nxp.com>,
<cristian.dumitrescu@intel.com>, <john.mcnamara@intel.com>,
<bruce.richardson@intel.com>, <anatoly.burakov@intel.com>,
<gavin.hu@arm.com>, <drc@linux.vnet.ibm.com>,
<konstantin.ananyev@intel.com>, <pallavi.kadam@intel.com>,
<olivier.matz@6wind.com>, <gage.eads@intel.com>, <nikhil.rao@intel.com>,
<erik.g.carrillo@intel.com>, <hemant.agrawal@nxp.com>,
<artem.andreev@oktetlabs.ru>, <sthemmin@microsoft.com>,
<shahafs@mellanox.com>, <keith.wiles@intel.com>,
<mattias.ronnblom@ericsson.com>, <jasvinder.singh@intel.com>,
<vladimir.medvedkin@intel.com>, <mdr@ashroe.eu>, <techboard@dpdk.org>
Message-ID: <20200202023817.3b7fb5d9@shemminger-XPS-13-9360>
In-Reply-To: <20200131170201.3236153-2-jerinj@marvell.com>
References: <20200131170201.3236153-1-jerinj@marvell.com>
<20200131170201.3236153-2-jerinj@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, 31 Jan 2020 22:31:57 +0530
<jerinj@marvell.com> wrote:
> +
> +#define set_err(err, where, fmt, ...) do { \
> + graph_err(fmt, ##__VA_ARGS__); \
> + rte_errno = err; \
> + goto where; \
> +} while (0)
I dislike this macro, it makes static analysis harder and requires
the reader to know that the argument is a goto target. And since it is lower
case, implies that it is a function. Usually macros are in upper case.
It makes the code smaller but a cost of being different which impacts the
readability of the code.