DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/e1000: use macro PCI_PRI_FMT for PCI log format
@ 2020-01-13 12:20 Yunjian Wang
  2020-02-02  6:55 ` Ye Xiaolong
  0 siblings, 1 reply; 2+ messages in thread
From: Yunjian Wang @ 2020-01-13 12:20 UTC (permalink / raw)
  To: dev, wenzhuo.lu; +Cc: xudingke, Yunjian Wang

Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/e1000/em_ethdev.c  | 2 +-
 drivers/net/e1000/igb_ethdev.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 080cbe2df..188cda350 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1605,7 +1605,7 @@ eth_em_interrupt_action(struct rte_eth_dev *dev,
 	} else {
 		PMD_INIT_LOG(INFO, " Port %d: Link Down", dev->data->port_id);
 	}
-	PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
+	PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
 		     pci_dev->addr.domain, pci_dev->addr.bus,
 		     pci_dev->addr.devid, pci_dev->addr.function);
 
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index a3e30dbe5..30e303c9b 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -2914,7 +2914,7 @@ eth_igb_interrupt_action(struct rte_eth_dev *dev,
 				     dev->data->port_id);
 		}
 
-		PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
+		PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
 			     pci_dev->addr.domain,
 			     pci_dev->addr.bus,
 			     pci_dev->addr.devid,
-- 
2.19.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/e1000: use macro PCI_PRI_FMT for PCI log format
  2020-01-13 12:20 [dpdk-dev] [PATCH] net/e1000: use macro PCI_PRI_FMT for PCI log format Yunjian Wang
@ 2020-02-02  6:55 ` Ye Xiaolong
  0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2020-02-02  6:55 UTC (permalink / raw)
  To: Yunjian Wang; +Cc: dev, wenzhuo.lu, xudingke

On 01/13, Yunjian Wang wrote:
>Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
>
>Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>---
> drivers/net/e1000/em_ethdev.c  | 2 +-
> drivers/net/e1000/igb_ethdev.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
>index 080cbe2df..188cda350 100644
>--- a/drivers/net/e1000/em_ethdev.c
>+++ b/drivers/net/e1000/em_ethdev.c
>@@ -1605,7 +1605,7 @@ eth_em_interrupt_action(struct rte_eth_dev *dev,
> 	} else {
> 		PMD_INIT_LOG(INFO, " Port %d: Link Down", dev->data->port_id);
> 	}
>-	PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
>+	PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
> 		     pci_dev->addr.domain, pci_dev->addr.bus,
> 		     pci_dev->addr.devid, pci_dev->addr.function);
> 
>diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
>index a3e30dbe5..30e303c9b 100644
>--- a/drivers/net/e1000/igb_ethdev.c
>+++ b/drivers/net/e1000/igb_ethdev.c
>@@ -2914,7 +2914,7 @@ eth_igb_interrupt_action(struct rte_eth_dev *dev,
> 				     dev->data->port_id);
> 		}
> 
>-		PMD_INIT_LOG(DEBUG, "PCI Address: %04d:%02d:%02d:%d",
>+		PMD_INIT_LOG(DEBUG, "PCI Address: " PCI_PRI_FMT,
> 			     pci_dev->addr.domain,
> 			     pci_dev->addr.bus,
> 			     pci_dev->addr.devid,
>-- 
>2.19.1
>
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-02  6:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 12:20 [dpdk-dev] [PATCH] net/e1000: use macro PCI_PRI_FMT for PCI log format Yunjian Wang
2020-02-02  6:55 ` Ye Xiaolong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).