From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67783A0531; Tue, 4 Feb 2020 09:59:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A12441C000; Tue, 4 Feb 2020 09:59:37 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id B1EA61BFAE for ; Tue, 4 Feb 2020 09:59:36 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id z9so9673368wrs.10 for ; Tue, 04 Feb 2020 00:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zj/V1XQQu7MA5q4GdBxCp951YowdesD1dNQFyTeTeRE=; b=wB7WOZ0eKeB9p2G7ib7ggxzfgehVZFRHFJtbEI0quefvkKxwkfNWJ0e1M57/mKUFVq wEFR5cWvO6ENzGakAxwygB6kbcuIXKzoPireX8lIDCMh7PBArBkxiKA2AE99/pJHzHyS 1ISurHe4CzarWN72+cHwJbPlI2145oW0wd1H8f04SNhOapdoZ5kKSP0YxEo0IEZcJCD9 Rzy+g6UXgSg3r+HsKzmQahSkHKOaJp3DMzwovDi7MdhLwCN/BThRvCQDXq9t+6V+fGS/ xCOohQDxKgPlknkGtVJyqrfePujO8xItG9nffkLbp5Asm0Dv6XxjO7EKV42cjYG2ePSB o1UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zj/V1XQQu7MA5q4GdBxCp951YowdesD1dNQFyTeTeRE=; b=h1nwC3paxoeSHNRXRtNcNR65BQSnN26oCWzPaFof0Mgz6Bk7zVHSO/xAFnDpaPVK6C Z+m0GH1HOlc16XJcBqqK00ijXHtm1Gfb/AL02CydH4AN6p1JfFwn8TdJe0+gssEFAyUC 63awSyhT/wiksH8NF4RWdSAAcXJC/A8I1aKhOyEVUJlkSMou4juMEFfQ6rUemHlSvtK/ IzLt22ROqBU+2IYQkSDoQ8IVj3ncNgswLelD7QoXorRqqrXfiRrCmqogBT1o/EEkOUyV /AzG2tUXGf5/+fDADKQT8fSNGX0519/nl13vud4PdmTC8rZqyPovIhGeS0vj/fGAdp9b zofA== X-Gm-Message-State: APjAAAU9SSQmVTSs7sLNS3pQpN8ttGorX8X6UIDzRe9SEYk2L8RHZKal vxT440VtWFuYT296MhxjWDUP+g== X-Google-Smtp-Source: APXvYqwYESKo8FjJfdkUUmR/X0KsmK8JJbAdaqPuYB2G6J1utJ7LVFbujp0oq0IMD1Gf367xWAcMuw== X-Received: by 2002:adf:dd46:: with SMTP id u6mr19981749wrm.13.1580806776277; Tue, 04 Feb 2020 00:59:36 -0800 (PST) Received: from shemminger-XPS-13-9360 ([212.187.182.162]) by smtp.gmail.com with ESMTPSA id c13sm11871390wrx.9.2020.02.04.00.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2020 00:59:36 -0800 (PST) Date: Tue, 4 Feb 2020 00:59:34 -0800 From: Stephen Hemminger To: Matan Azrad Cc: Viacheslav Ovsiienko , dev@dpdk.org Message-ID: <20200204005934.07fe2468@shemminger-XPS-13-9360> In-Reply-To: <1580659153-25436-1-git-send-email-matan@mellanox.com> References: <1580659153-25436-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 2 Feb 2020 15:59:13 +0000 Matan Azrad wrote: > The new RDMA-CORE versions may have the same sub-path to include the > linux Netlink header file. > > It uses the pre-proccessor command #include_next what breaks the PMD gcc > compilation of common/mlx5_netlink.h file in debug mode. > > Use specific include for linux/netlink.h to be taken from > /usr/include/linux. > > Signed-off-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_nl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/common/mlx5/mlx5_nl.h b/drivers/common/mlx5/mlx5_nl.h > index 2c3f837..ebaa655 100644 > --- a/drivers/common/mlx5/mlx5_nl.h > +++ b/drivers/common/mlx5/mlx5_nl.h > @@ -5,7 +5,7 @@ > #ifndef RTE_PMD_MLX5_NL_H_ > #define RTE_PMD_MLX5_NL_H_ > > -#include > +#include "/usr/include/linux/netlink.h" I think this should be fixed with CFLAGS, not hard coding path to netlink.h Doing it this way is sure to break some cross build environments.