From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 435E4A0535; Wed, 5 Feb 2020 00:08:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA17C1C1F2; Wed, 5 Feb 2020 00:08:51 +0100 (CET) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id EC8391C12F for ; Wed, 5 Feb 2020 00:08:49 +0100 (CET) Received: by mail-lj1-f193.google.com with SMTP id v17so393690ljg.4 for ; Tue, 04 Feb 2020 15:08:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DA+e8HytgQTB4IoYFmp/bDEX8PyYoeOfqCCP040c0i4=; b=qEJc8251g4gm4zGioFshc/jdhzZ+/68BYqCcT289Nt3K8AldaqRUTfxTim8ZaYpV4f ZZHP5gskI902KO5ICLNg8cswflqB9Z8MMU2X+bNUMIQ/K7mT7clSZAx84iByBZhR1IPb 6P73D0YJxRZOokYXFhlULHMucZoYZp+xD639+AmaxBYUmDsVagZB3gFc+Y9PoiWdfTjS 2MyqyV0PWu1NVq42H5Z1h2MpQuu+CSXe7E6sX/w3UeEcGy0GLmKoRaBp8F5oKNxa6s4f xp8LSJyg8LW+D9IXI97tU76RDYrPtK5zEPKjlr+SQKtEki76JY3z1nl85IaCFBbZqSe6 mrdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DA+e8HytgQTB4IoYFmp/bDEX8PyYoeOfqCCP040c0i4=; b=S6T89+xOW4634jTnqjmU8FhGcg8KorQQ+6YM4KtR8VfdHCofYF4YToRfK6OMHFC52V XsyF0Spy+05mQJr2Yso2TANnJkk11AWFM1QAO7rBlaEedRpO86tQxk39voRGVzdpMFbx ZijLeY05qgifW7UWQPPcW9xxG+nK5qkJCJJX+Q9ygFGvQs9gcw1+M3UCI+Xshv+bW3pR RWOe0NqkYoC2eF0yDbVCTqEVgb8/MhBDvblhSz6jj/aEzBkTcn/7m+MkpJSNnOdqGlwj V40zBZJFc1gLFfpkZj54Oyvhh04nT1glozsg3B/vqvHwj+nKjWgvm/PgJEbBP4otzoaQ iVgg== X-Gm-Message-State: APjAAAUUDYohZOfEHst1crDiKMIZ0iWXxIdlGz+4s/VO6sNXL5nV4is2 7CEl2a+NiZN4k5pCVCz1Nzk= X-Google-Smtp-Source: APXvYqxOeKYJjkgMKdfOUZyo264U73lK8P7ltPSQ9fXD8n4AlSVWvDgzHIjyNkITsjstjncUstSDtA== X-Received: by 2002:a2e:978d:: with SMTP id y13mr18399308lji.103.1580857729478; Tue, 04 Feb 2020 15:08:49 -0800 (PST) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v9sm12920505lfe.18.2020.02.04.15.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2020 15:08:48 -0800 (PST) Date: Wed, 5 Feb 2020 02:08:47 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Message-ID: <20200205020847.3827b05f@Sovereign> In-Reply-To: <2019930.Icojqenx9y@xps> References: <20200131052421.33525-1-dmitry.kozliuk@gmail.com> <2019930.Icojqenx9y@xps> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/windows: refine public interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > I agree bloating rte_os.h is a concern. > If you can achieve the initial goal (no specific include in apps, libs > and drivers) while reducing rte_os.h, I think it is good. would be such a specific include, like in Linux EAL. This file would include Windows platform SDK files in the right order, define feature macros and maybe error-handling macros, so that EAL users could just access Windows SDK in one line without being bothered by details and having handy macros as a bonus. > This file is compiled only on Windows. > What do you mean with "portable"? By "portable" I mean not breaking OS-independent code with Windows defines. Item 1 gives "min", "max" and "ERROR" macros as examples. Also, some Windows includes must come after the others, e.g. (Berkeley sockets) must come strictly after , and it's not an isolated case. > > Fixes: 428eb983 ("eal: add OS specific header file") > > nit: blank line missing here Thanks, I've little experience sending patches. -- Dmitry Kozlyuk