From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 762FCA0535; Wed, 5 Feb 2020 00:21:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA2991C21A; Wed, 5 Feb 2020 00:21:41 +0100 (CET) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by dpdk.org (Postfix) with ESMTP id 1C9EA1C12F for ; Wed, 5 Feb 2020 00:21:40 +0100 (CET) Received: by mail-lj1-f178.google.com with SMTP id a13so385416ljm.10 for ; Tue, 04 Feb 2020 15:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HrNyFLEpXU7xylD68m/FQdlDt0sk0QlhSc293zNba3w=; b=JuhkL2gNTepa9DmRzQmy8goE6ppX0UnsMQwzEUxTpRbW6PRaCPXyZn6ZrdCWjAuYWU SUGcVl6LRD1y9mLw+3z0KJcdChMA8g4JBmpSw+95YuKpozH6F8+XKzHj9Z1O0R8q7lBc Tk1s3wSleydt1pARQM8bwrXaPM3c/GbznbzWUby8E+2Bkwb7RZags5V6kBlIqRYSjndu Sp80BSTMLt1DG5q0VoETLWr2xtLz1YLFkjrlNu9EmnK04TdzR/Ge+wleLiAgj5UyfjUc O32uSsM5yLk01+JSsVLzFlQagIiq8daL/KTeGDHfAFgwDCLPyZMDkInr5K+2lHo88Y7h Em3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HrNyFLEpXU7xylD68m/FQdlDt0sk0QlhSc293zNba3w=; b=iNETqAoDFaguhyGdoMYYGTvbQmBpyR8tlGIliNIOMr0qSl5Tba+t0UuEehFdTyacKY WKoDnFYb0gHPOwmJa6KUJZuMJarfdtyHhlkZbZpNrV944eJeKdaeWZ6pahe3ZaQavFO7 3B6aE1/LulU3IrARzsuaIAkEXFjXuPNSC6jm/MjwaqjbytDj6HCZ3waH3W4KXseFMuUA xq3YCqGIVBpAshma6qkLq+3ZcUeLX42ahdV2hRIa2LyzysBW5xoCH5+HqKXzb0oQAo6t vsVKEhl4pIr16cpTzs1PA+BgOaxLl41rO9PvBxZ1dWTRVMcYnFXyscr11HeEWtT9dJAp NPZw== X-Gm-Message-State: APjAAAUmCQ+ag5PFHnPNy2UK2L6NclJP5eMdzf/upUqG5k/C9aBq3hTJ z518BOUy2N9mDihdf6E5gIg= X-Google-Smtp-Source: APXvYqwZ0zZ3cZYPx8f/8tpiAyMlIqLKJo+KRDxgv3eWQC9qPp3fbjjUFhqeCYPA+5t6ARt3HAKzVQ== X-Received: by 2002:a2e:6c06:: with SMTP id h6mr18663840ljc.246.1580858499492; Tue, 04 Feb 2020 15:21:39 -0800 (PST) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id d22sm11185249lfi.49.2020.02.04.15.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2020 15:21:38 -0800 (PST) Date: Wed, 5 Feb 2020 02:21:38 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, Bruce Richardson , harini.ramakrishnan@microsoft.com Message-ID: <20200205022138.68c6b854@Sovereign> In-Reply-To: <2199644.NG923GbCHz@xps> References: <20200131030744.19596-1-dmitry.kozliuk@gmail.com> <20200131030744.19596-5-dmitry.kozliuk@gmail.com> <2199644.NG923GbCHz@xps> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > I really like this patch. > So both GCC (with MinGW) and native clang are supported? Thanks. Yes, I tested both toolchains. > [...] > > +# MS linker requires special treatment. > > +# FIXME: use cc.get_linker_id() after upgrading to Meson >=0.53. > > What does it mean? It won't work with meson 0.53? It will work for any Meson version, I meant that Meson 0.54 will introduce a better way to determine linker ID. Can you suggest a better wording? > > > +is_ms_linker = is_windows and (cc.get_id() == 'clang') > [...] > > +if is_windows > > + # Require platform SDK for Windows 7 and above. > > + add_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c') > > Please explain. Why Windows 7 is needed? What this define is doing? Yes, Windows 7 and above is need for already existing code in eal_lcore.c, specifically for GetLogicalProcessorInformation() call. When including , one must define minimum API version the application is compiled against [0]. MSVC and Clang default to the version of platform SDK (that is, maximum supported). MinGW defaults to Windows XP, so this definition must be either in before #include or here. Because other files may include , I'd prefer to have a global definition via compiler command-line. [0]: https://docs.microsoft.com/en-us/windows/win32/WinProg/using-the-windows-headers -- Dmitry Kozlyuk