From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27F94A04FA; Wed, 5 Feb 2020 15:30:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA7C01C1FB; Wed, 5 Feb 2020 15:30:58 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CED141C1B3 for ; Wed, 5 Feb 2020 15:30:56 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 06:30:55 -0800 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="224668827" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 05 Feb 2020 06:30:54 -0800 Date: Wed, 5 Feb 2020 14:30:50 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Dmitry Kozlyuk , dev@dpdk.org, harini.ramakrishnan@microsoft.com Message-ID: <20200205143050.GB687@bricha3-MOBL.ger.corp.intel.com> References: <20200131030744.19596-1-dmitry.kozliuk@gmail.com> <2199644.NG923GbCHz@xps> <20200205022138.68c6b854@Sovereign> <12853507.RDIVbhacDa@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12853507.RDIVbhacDa@xps> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 05, 2020 at 01:41:24AM +0100, Thomas Monjalon wrote: > 05/02/2020 00:21, Dmitry Kozlyuk: > > > I really like this patch. > > > So both GCC (with MinGW) and native clang are supported? > > > > Thanks. Yes, I tested both toolchains. > > > > > [...] > > > > +# MS linker requires special treatment. > > > > +# FIXME: use cc.get_linker_id() after upgrading to Meson >=0.53. > > > > > > What does it mean? It won't work with meson 0.53? > > > > It will work for any Meson version, I meant that Meson 0.54 will introduce a > > better way to determine linker ID. Can you suggest a better wording? > > FIXME: use cc.get_linker_id() with Meson >= 0.54 > > > > > > +is_ms_linker = is_windows and (cc.get_id() == 'clang') > > > [...] > > > > +if is_windows > > > > + # Require platform SDK for Windows 7 and above. > > > > + add_project_arguments('-D_WIN32_WINNT=0x0601', language: 'c') > > > > > > Please explain. Why Windows 7 is needed? What this define is doing? > > > > Yes, Windows 7 and above is need for already existing code in eal_lcore.c, > > specifically for GetLogicalProcessorInformation() call. > > > > When including , one must define minimum API version the > > application is compiled against [0]. MSVC and Clang default to the version of > > platform SDK (that is, maximum supported). MinGW defaults to Windows XP, so > > this definition must be either in before #include or > > here. Because other files may include , I'd prefer to have a > > global definition via compiler command-line. > > > > [0]: > > https://docs.microsoft.com/en-us/windows/win32/WinProg/using-the-windows-headers > > OK, thanks. > Please reword the comment with something like > "Minimum supported API is Windows 7." > For this, as an alternative to putting it as a project argument, you can just add it to dpdk_conf which means it will end up as a define in the global rte_build_config.h and so be directly included in each compilation unit ahead of any other headers. (rte_config.h includes rte_build_config.h) /Bruce