From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 583DBA04FA; Thu, 6 Feb 2020 02:39:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44E1E1C21F; Thu, 6 Feb 2020 02:39:40 +0100 (CET) Received: from valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by dpdk.org (Postfix) with ESMTP id 0015D1C200; Thu, 6 Feb 2020 02:39:37 +0100 (CET) Received: by valinux.co.jp (Postfix, from userid 1000) id 50440240977; Thu, 6 Feb 2020 10:39:36 +0900 (JST) From: Itsuro Oda To: dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, anatoly.burakov@intel.com Cc: stable@dpdk.org Date: Thu, 6 Feb 2020 10:39:33 +0900 Message-Id: <20200206013936.11119-2-oda@valinux.co.jp> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200206013936.11119-1-oda@valinux.co.jp> References: <20200108062510.3478-1-oda@valinux.co.jp> <20200206013936.11119-1-oda@valinux.co.jp> Subject: [dpdk-dev] [PATCH v3 1/4] net/vhost: allocate interface name from heap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch allocates iface_name of pmd_internal from heap in order to be able to refer from secondary processes. Fixes: 4852aa8f6e21 (drivers/net: enable hotplug on secondary process) Cc: stable@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index a63588986..cea2ead2d 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1009,7 +1009,7 @@ eth_dev_close(struct rte_eth_dev *dev) rte_free(dev->data->tx_queues[i]); free(internal->dev_name); - free(internal->iface_name); + rte_free(internal->iface_name); rte_free(internal); dev->data->dev_private = NULL; @@ -1256,9 +1256,11 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name, internal->dev_name = strdup(name); if (internal->dev_name == NULL) goto error; - internal->iface_name = strdup(iface_name); + internal->iface_name = rte_malloc_socket(name, strlen(iface_name) + 1, + 0, numa_node); if (internal->iface_name == NULL) goto error; + strcpy(internal->iface_name, iface_name); list->eth_dev = eth_dev; pthread_mutex_lock(&internal_list_lock); @@ -1306,7 +1308,7 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name, error: if (internal) { - free(internal->iface_name); + rte_free(internal->iface_name); free(internal->dev_name); } rte_free(vring_state); -- 2.17.0