DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: dev@dpdk.org
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: [dpdk-dev] [PATCH v2 1/7] eal: introduce portable format attribute
Date: Thu,  6 Feb 2020 09:44:20 +0300	[thread overview]
Message-ID: <20200206064426.45697-2-dmitry.kozliuk@gmail.com> (raw)
In-Reply-To: <20200206064426.45697-1-dmitry.kozliuk@gmail.com>

When using __attribute__((format(...)) on functions, GCC on Windows
assumes MS-specific format string by default, even if the underlying
stdio implementation is ANSI-compliant (either MS Unicersal CRT
or MinGW implementation). Wrap attribute into a macro that forces
GNU-specific format string when using GCC.

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 lib/librte_eal/common/include/rte_common.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
index 4b5f3a31f..2f086bb9c 100644
--- a/lib/librte_eal/common/include/rte_common.h
+++ b/lib/librte_eal/common/include/rte_common.h
@@ -89,6 +89,21 @@ typedef uint16_t unaligned_uint16_t;
  */
 #define RTE_SET_USED(x) (void)(x)
 
+/**
+ * Check format string and its arguments at compile-time.
+ *
+ * GCC on Windows assumes MS-specific format string by default,
+ * even if the underlying stdio implementation is ANSI-compliant,
+ * so this must be overridden.
+ */
+#if defined(RTE_TOOLCHAIN_GCC)
+#define __rte_format(archetype, format_index, first_arg) \
+	__attribute__((format(gnu_##archetype, format_index, first_arg)))
+#else
+#define __rte_format(archetype, format_index, first_arg) \
+	__attribute__((format(archetype, format_index, first_arg)))
+#endif
+
 #define RTE_PRIORITY_LOG 101
 #define RTE_PRIORITY_BUS 110
 #define RTE_PRIORITY_CLASS 120
-- 
2.25.0


  reply	other threads:[~2020-02-06  6:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06  6:44 [dpdk-dev] [PATCH v2 0/7] MinGW-w64 support Dmitry Kozlyuk
2020-02-06  6:44 ` Dmitry Kozlyuk [this message]
2020-02-06  6:44 ` [dpdk-dev] [PATCH v2 2/7] eal: use portable format attribute Dmitry Kozlyuk
2020-02-06  6:44 ` [dpdk-dev] [PATCH v2 3/7] cmdline: " Dmitry Kozlyuk
2020-02-06  6:44 ` [dpdk-dev] [PATCH v2 4/7] eal/windows: use lowercase filenames for system headers Dmitry Kozlyuk
2020-02-06  6:44 ` [dpdk-dev] [PATCH v2 5/7] build: MinGW-w64 support for Meson Dmitry Kozlyuk
2020-02-06 11:38   ` Bruce Richardson
2020-02-06  6:44 ` [dpdk-dev] [PATCH v2 6/7] build: add cross-file for MinGW-w64 Dmitry Kozlyuk
2020-02-06  6:44 ` [dpdk-dev] [PATCH v2 7/7] doc: guide for Windows build using MinGW-w64 Dmitry Kozlyuk
2020-02-06 20:22 ` [dpdk-dev] [PATCH v2 0/7] MinGW-w64 support William Tu
2020-02-07 10:24   ` Dmitry Kozliuk
2020-02-07 17:47     ` William Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206064426.45697-2-dmitry.kozliuk@gmail.com \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).