From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46B89A0531; Mon, 10 Feb 2020 04:07:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 316541BEA9; Mon, 10 Feb 2020 04:07:50 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id F0F4C1BDF8; Mon, 10 Feb 2020 04:07:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2020 19:07:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,423,1574150400"; d="scan'208";a="280513519" Received: from dpdk-xiaoyunl.sh.intel.com ([10.67.110.162]) by FMSMGA003.fm.intel.com with ESMTP; 09 Feb 2020 19:07:45 -0800 From: Xiaoyun Li To: xiaolong.ye@intel.com, marko.kovacevic@intel.com Cc: dev@dpdk.org, Xiaoyun Li , stable@dpdk.org Date: Mon, 10 Feb 2020 11:07:57 +0800 Message-Id: <20200210030757.11426-1-xiaoyun.li@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] examples/tep_term: fix return value check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Added return value check for 'rte_eth_dev_info_get()'. Coverity issue: 349922 Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") Cc: stable@dpdk.org Signed-off-by: Xiaoyun Li --- examples/tep_termination/vxlan_setup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/tep_termination/vxlan_setup.c b/examples/tep_termination/vxlan_setup.c index eca119a72..bd469f5f4 100644 --- a/examples/tep_termination/vxlan_setup.c +++ b/examples/tep_termination/vxlan_setup.c @@ -195,7 +195,9 @@ vxlan_port_init(uint16_t port, struct rte_mempool *mbuf_pool) if (tso_segsz != 0) { struct rte_eth_dev_info dev_info; - rte_eth_dev_info_get(port, &dev_info); + retval = rte_eth_dev_info_get(port, &dev_info); + if (retval != 0) + return -retval; if ((dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) == 0) RTE_LOG(WARNING, PORT, "hardware TSO offload is not supported\n"); -- 2.17.1