From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Guinan Sun <guinanx.sun@intel.com>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Qiming Yang <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix coverity issue
Date: Mon, 10 Feb 2020 14:57:44 +0800 [thread overview]
Message-ID: <20200210065744.GC80720@intel.com> (raw)
In-Reply-To: <20200210041525.50893-1-guinanx.sun@intel.com>
On 02/10, Guinan Sun wrote:
>This patch fixes (Logically dead code) coverity issue.
>
>Coverity issue: 353613
>Fixes: 3c4270187518 ("net/ixgbe: support VF MAC address add/remove")
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
> drivers/net/ixgbe/ixgbe_pf.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
>index 493f0f2b9..afae21f81 100644
>--- a/drivers/net/ixgbe/ixgbe_pf.c
>+++ b/drivers/net/ixgbe/ixgbe_pf.c
>@@ -772,9 +772,6 @@ ixgbe_set_vf_macvlan_msg(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)
> IXGBE_VT_MSGINFO_SHIFT;
>
> if (index) {
>- if (new_mac == NULL)
>- return -1;
>-
> if (!rte_is_valid_assigned_ether_addr(
> (struct rte_ether_addr *)new_mac)) {
> PMD_DRV_LOG(ERR, "set invalid mac vf:%d\n", vf);
>--
>2.17.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
next prev parent reply other threads:[~2020-02-10 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 4:15 Guinan Sun
2020-02-10 6:57 ` Ye Xiaolong [this message]
2020-02-11 7:13 Shougang Wang
2020-02-11 8:27 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210065744.GC80720@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=guinanx.sun@intel.com \
--cc=qiming.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).