From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7340CA0531;
Mon, 10 Feb 2020 08:04:51 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A39471BE9C;
Mon, 10 Feb 2020 08:04:50 +0100 (CET)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 50A79262E;
Mon, 10 Feb 2020 08:04:48 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
09 Feb 2020 23:04:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.70,424,1574150400"; d="scan'208";a="226062600"
Received: from dpdk-xiaoyunl.sh.intel.com ([10.67.110.162])
by orsmga008.jf.intel.com with ESMTP; 09 Feb 2020 23:04:45 -0800
From: Xiaoyun Li <xiaoyun.li@intel.com>
To: xiaolong.ye@intel.com,
marko.kovacevic@intel.com
Cc: dev@dpdk.org,
Xiaoyun Li <xiaoyun.li@intel.com>,
stable@dpdk.org
Date: Mon, 10 Feb 2020 15:04:58 +0800
Message-Id: <20200210070458.20865-1-xiaoyun.li@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200210030757.11426-1-xiaoyun.li@intel.com>
References: <20200210030757.11426-1-xiaoyun.li@intel.com>
Subject: [dpdk-dev] [PATCH v2] examples/tep_term: fix return value check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Added return value check for 'rte_eth_dev_info_get()'.
Coverity issue: 349922
Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration")
Cc: stable@dpdk.org
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
examples/tep_termination/vxlan_setup.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/examples/tep_termination/vxlan_setup.c b/examples/tep_termination/vxlan_setup.c
index eca119a72..f8385b690 100644
--- a/examples/tep_termination/vxlan_setup.c
+++ b/examples/tep_termination/vxlan_setup.c
@@ -195,7 +195,9 @@ vxlan_port_init(uint16_t port, struct rte_mempool *mbuf_pool)
if (tso_segsz != 0) {
struct rte_eth_dev_info dev_info;
- rte_eth_dev_info_get(port, &dev_info);
+ retval = rte_eth_dev_info_get(port, &dev_info);
+ if (retval != 0)
+ return retval;
if ((dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) == 0)
RTE_LOG(WARNING, PORT,
"hardware TSO offload is not supported\n");
--
2.17.1