From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E6A8A04B3; Mon, 10 Feb 2020 10:53:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 044D21BDFD; Mon, 10 Feb 2020 10:53:59 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id AB77254AE for ; Mon, 10 Feb 2020 10:53:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 0D36066C1; Mon, 10 Feb 2020 04:53:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 10 Feb 2020 04:53:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=zugr937hoHqCy78ayl+PQEe uJoh00UGFo5lggfyWdVg=; b=QoLLHMlYhlfk4s5kQnWTdD2eViYC738L9fN3fj5 jVn3vX7O3NDWU/la1Uw8ekjjnxGVtCKprnibJdbLbrl4rc1f3Jpx4+aGZ+zASAzm 2rxUfsnHDUuiI+12W9iWEI0UfO7C1xgZjxKAVhhx8zHc4xNMGWcq1bpXvUQjne6p oPnQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zugr937hoHqCy78ay l+PQEeuJoh00UGFo5lggfyWdVg=; b=ljonChNePcFOBZIH6uhK3JjShrFdO42LB mPydJ8DSeapNYKcsiJTcLqdSwc/gm55k+C3znAYiL8Q3LCNEKuYTW5isdzat1BCy M+okUeVcbgB9K9mkf/BiBS7tspsiogjQ5sjZ+R0EsAXXq7I0fDKP5RbkXJWxjiWs EkKYdTug25BJ9odjQigzvUToVtt0j+l+5mKbJ+IFP8+n9XCYF6LQH1OTy8aMIBI2 0nKsv0xUD72ljvDIAoimb1hYQOh6TQAfJc+qH9pjCNsIzDCfEXe6sU1csOGs557s TqKTVbXCfQtQP8RbmuFaTGloQL0y3e2nfOr4vyOEtswZRx7x6it/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepje ejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D3688328005E; Mon, 10 Feb 2020 04:53:54 -0500 (EST) From: Thomas Monjalon To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Neil Horman , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Ravi Kumar , Xiaolong Ye , Qi Zhang , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou Cc: dev@dpdk.org Date: Mon, 10 Feb 2020 10:53:34 +0100 Message-Id: <20200210095334.1167059-1-thomas@monjalon.net> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] build: remove redundant config include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The header file rte_config.h is always included by make or meson. If required in an exported API header file, it must be included in the public header file for external applications. In the internal files, explicit include of rte_config.h is useless, and can be removed. Signed-off-by: Thomas Monjalon --- app/test-pmd/config.c | 1 - buildtools/pmdinfogen/pmdinfogen.h | 1 - drivers/common/mlx5/mlx5_glue.c | 2 -- drivers/crypto/ccp/rte_ccp_pmd.c | 1 - drivers/net/af_xdp/rte_eth_af_xdp.c | 1 - drivers/net/failsafe/failsafe_intr.c | 1 - drivers/net/hinic/base/hinic_compat.h | 1 - drivers/net/mlx4/mlx4.c | 1 - drivers/net/mlx5/mlx5.c | 1 - drivers/net/vdev_netvsc/vdev_netvsc.c | 1 - lib/librte_eal/common/eal_common_mcfg.c | 1 - lib/librte_eal/common/eal_memcfg.h | 1 - 12 files changed, 13 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 9669cbd4cb..67840d86b7 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -49,7 +49,6 @@ #include #endif #include -#include #include "testpmd.h" diff --git a/buildtools/pmdinfogen/pmdinfogen.h b/buildtools/pmdinfogen/pmdinfogen.h index c8a9e2136a..160867b9f3 100644 --- a/buildtools/pmdinfogen/pmdinfogen.h +++ b/buildtools/pmdinfogen/pmdinfogen.h @@ -24,7 +24,6 @@ #include #include #include -#include #include /* On BSD-alike OSes elf.h defines these according to host's word size */ diff --git a/drivers/common/mlx5/mlx5_glue.c b/drivers/common/mlx5/mlx5_glue.c index 27cf33cdb9..0af0b86677 100644 --- a/drivers/common/mlx5/mlx5_glue.c +++ b/drivers/common/mlx5/mlx5_glue.c @@ -14,8 +14,6 @@ */ #include -#include - #include "mlx5_glue.h" static int diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c index b5bb6790bc..f6ea008444 100644 --- a/drivers/crypto/ccp/rte_ccp_pmd.c +++ b/drivers/crypto/ccp/rte_ccp_pmd.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 683e2a5594..ed784dff19 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/net/failsafe/failsafe_intr.c b/drivers/net/failsafe/failsafe_intr.c index 0f34c5bbac..d8728fe7e3 100644 --- a/drivers/net/failsafe/failsafe_intr.c +++ b/drivers/net/failsafe/failsafe_intr.c @@ -13,7 +13,6 @@ #include #include -#include #include #include #include diff --git a/drivers/net/hinic/base/hinic_compat.h b/drivers/net/hinic/base/hinic_compat.h index e4a7f12d15..b72e8cfe26 100644 --- a/drivers/net/hinic/base/hinic_compat.h +++ b/drivers/net/hinic/base/hinic_compat.h @@ -18,7 +18,6 @@ #include #include #include -#include typedef uint8_t u8; typedef int8_t s8; diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 5522eb595c..a1dd658176 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -29,7 +29,6 @@ #endif #include -#include #include #include #include diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index b4ec6cba1a..23a50f3f92 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -29,7 +29,6 @@ #include #include #include -#include #include #include #include diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index be8f19c0c6..9ed74a1d6a 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include #include diff --git a/lib/librte_eal/common/eal_common_mcfg.c b/lib/librte_eal/common/eal_common_mcfg.c index 36a8ca8fcf..49d3ed0ce5 100644 --- a/lib/librte_eal/common/eal_common_mcfg.c +++ b/lib/librte_eal/common/eal_common_mcfg.c @@ -2,7 +2,6 @@ * Copyright(c) 2019 Intel Corporation */ -#include #include #include diff --git a/lib/librte_eal/common/eal_memcfg.h b/lib/librte_eal/common/eal_memcfg.h index 4d650025c2..583fcb5953 100644 --- a/lib/librte_eal/common/eal_memcfg.h +++ b/lib/librte_eal/common/eal_memcfg.h @@ -5,7 +5,6 @@ #ifndef EAL_MEMCFG_H #define EAL_MEMCFG_H -#include #include #include #include -- 2.25.0