From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78E62A051C; Tue, 11 Feb 2020 12:33:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5885C2BF4; Tue, 11 Feb 2020 12:33:30 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3FA192BD8 for ; Tue, 11 Feb 2020 12:33:28 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 03:33:27 -0800 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="221905540" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.79]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Feb 2020 03:33:25 -0800 Date: Tue, 11 Feb 2020 11:33:22 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20200211113322.GC823@bricha3-MOBL.ger.corp.intel.com> References: <20200127154402.4008069-1-thomas@monjalon.net> <20200211011942.1569573-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200211011942.1569573-1-thomas@monjalon.net> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v3 0/5] mlx ibverbs linking in meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 11, 2020 at 02:19:37AM +0100, Thomas Monjalon wrote: > This is the follow-up of the feature I added one year ago: > static linkage of libibverbs in mlx PMDs. > The first implementation was focused on "make". > This second round does the same with "meson". > > With the meson option ibverbs_link, only the mode "shared" > was working correctly. > This patchset adds the mode "static" and fixes the mode "dlopen". > > > changes in v3: > - get cflags with pkg-config invocation > - drop addition of global variable hidden_deps > - remove overlinking in dlopen mode > > changes in v2: > - split mlx patch for normal addition and workarounds > - fix ldflags for ibverbs installed in a standard directory > - fix libs order leading to undefined references > - add doc for hidden_deps > - improve explanations in commit logs > > > Thomas Monjalon (5): > net/mlx: add static ibverbs linkage with meson > buildtools: get static mlx dependencies for meson > net/mlx: workaround static linkage with meson > net/mlx: rename meson variable for dlopen option > net/mlx: fix overlinking with meson and glue dlopen > Send a couple of improvement suggestions for two of the patches, but otherwise looks ok to me. Series-acked-by: Bruce Richardson