From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8B89A0530; Wed, 12 Feb 2020 11:47:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D820E262E; Wed, 12 Feb 2020 11:47:35 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 066BF2629 for ; Wed, 12 Feb 2020 11:47:33 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 02:47:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="266621058" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by fmsmga002.fm.intel.com with ESMTP; 12 Feb 2020 02:47:31 -0800 Date: Wed, 12 Feb 2020 18:47:22 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: Ivan Dyukov , dev@dpdk.org, amorenoz@redhat.com Message-ID: <20200212104722.GA787272@___> References: <20200207112526.11455-1-i.dyukov@samsung.com> <20200207112526.11455-2-i.dyukov@samsung.com> <20200212103528.GA786542@___> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 12, 2020 at 11:40:40AM +0100, Maxime Coquelin wrote: > On 2/12/20 11:35 AM, Tiwei Bie wrote: > > On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: > >> Some applications like pktgen use link_speed to calculate > >> transmit rate. It limits outcome traffic to hardcoded 10G. > >> > >> This patch adds link_speed devarg which allows to configure > >> link_speed of virtio device. > >> > >> Signed-off-by: Ivan Dyukov > >> --- > >> doc/guides/nics/virtio.rst | 7 ++ > >> drivers/net/virtio/virtio_ethdev.c | 101 ++++++++++++++++++++++++----- > >> drivers/net/virtio/virtio_pci.h | 1 + > >> 3 files changed, 92 insertions(+), 17 deletions(-) > > > > Maybe I missed something.. Why not enable the VIRTIO_NET_F_SPEED_DUPLEX > > support directly? When that feature is supported and negotiated, > > we will ignore this devarg? > > IMHO, yes. When VIRTIO_NET_F_SPEED_DUPLEX will be implemented and > negotiated, this devarg will be ignored. Thanks for the clarification. > > > If we want this devarg, it looks better to support it in virtio-user > > as well (most code is shared between virtio-PMD and virtio-user). > > That's a valid point, Virtio-user should also support it. > Ivan, can you send a new revision with Virtio-user support as well? Thanks! Regards, Tiwei > > Thanks, > Maxime > > > Thanks! > > Tiwei > > >