From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AFBBA0546; Fri, 14 Feb 2020 10:47:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 275011F28; Fri, 14 Feb 2020 10:47:04 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CD6681DB9 for ; Fri, 14 Feb 2020 10:47:01 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 01:47:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,440,1574150400"; d="scan'208";a="227342943" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga007.fm.intel.com with ESMTP; 14 Feb 2020 01:46:59 -0800 Date: Fri, 14 Feb 2020 17:45:34 +0800 From: Ye Xiaolong To: Beilei Xing Cc: dev@dpdk.org, qi.z.zhang@intel.com Message-ID: <20200214094534.GA16933@intel.com> References: <1581447720-29099-1-git-send-email-beilei.xing@intel.com> <1581510961-96878-1-git-send-email-beilei.xing@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1581510961-96878-1-git-send-email-beilei.xing@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/12, Beilei Xing wrote: >This patch fixes unchecked return value >of the i40e_xmit_cleanup function. > >Coverity issue: 353617 >Fixes: 4861cde46116 ("i40e: new poll mode driver") > >Signed-off-by: Beilei Xing >--- >V2 change: > - Use cast. > > drivers/net/i40e/i40e_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c >index fd1ae80..f6d23c9 100644 >--- a/drivers/net/i40e/i40e_rxtx.c >+++ b/drivers/net/i40e/i40e_rxtx.c >@@ -1039,7 +1039,7 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > /* Check if the descriptor ring needs to be cleaned. */ > if (txq->nb_tx_free < txq->tx_free_thresh) >- i40e_xmit_cleanup(txq); >+ (void)i40e_xmit_cleanup(txq); > > for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { > td_cmd = 0; >-- >2.7.4 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.