From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19B1DA0556; Sat, 22 Feb 2020 00:50:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CAFB1BFAD; Sat, 22 Feb 2020 00:50:45 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8E5911BFAC for ; Sat, 22 Feb 2020 00:50:43 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2020 15:50:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,470,1574150400"; d="scan'208";a="283851951" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by FMSMGA003.fm.intel.com with ESMTP; 21 Feb 2020 15:50:41 -0800 Date: Sat, 22 Feb 2020 07:50:20 +0800 From: Tiwei Bie To: Thomas Monjalon Cc: Maxime Coquelin , dev@dpdk.org, Zhihong Wang Message-ID: <20200221235020.GA103347@___> References: <20200219103923.2259246-1-thomas@monjalon.net> <20200220025240.GA45390@___> <3026524.oiGErgHkdL@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3026524.oiGErgHkdL@xps> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] examples/vhost_blk: use common macros for min/max X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 21, 2020 at 07:29:13PM +0100, Thomas Monjalon wrote: > 20/02/2020 03:52, Tiwei Bie: > > On Wed, Feb 19, 2020 at 11:39:22AM +0100, Thomas Monjalon wrote: > > > The macros RTE_MIN and RTE_MAX can be used in DPDK applications. > > Only RTE_MIN is used in this patch. The title is wrong as well. Make sense! The commit log should describe what's changed by the patch exactly. > > > > > This change implies fixing the sign of used_len as size_t > > > as defined in vhost_strcpy_pad(). > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > examples/vhost_blk/blk.c | 4 ++-- > > > examples/vhost_blk/vhost_blk.h | 2 -- > > > examples/vhost_blk/vhost_blk_compat.c | 2 +- > > > 3 files changed, 3 insertions(+), 5 deletions(-) > > > > Reviewed-by: Tiwei Bie > > >