DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>, dev <dev@dpdk.org>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation
Date: Tue, 25 Feb 2020 16:55:41 -0800
Message-ID: <20200225165541.01c06952@hermes.lan> (raw)
In-Reply-To: <20200207142959.GR22738@platinum>

On Fri, 7 Feb 2020 15:29:59 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:

> The meaning of each flag should be as simple as possible, I think we can
> summarize them like this:
> 
> - PKT_RX_VLAN: the vlan is saved in vlan tci.
> - PKT_RX_VLAN_STRIPPED: the vlan hdr is removed from packet data.
> - PKT_RX_QINQ: the outer vlan is saved in vlan tci.
> - PKT_RX_QINQ_STRIPPED: the inner vlan is stripped from packet data.
> - When PKT_RX_QINQ is set, PKT_RX_VLAN* refer to the inner vlan
>   of initial packet, else it refers to the first vlan of the packet.
> 
> There is a link between vlan flag and vlan_tci field, and qinq flag and
> vlan_tci_outer field.
> 
> I'm still not sure to understand what you expect. Can you give an
> example with flags (which are set), and the expected content of m->vlan_tci
> and m->vlan_tci_outer?
> 
> By the way, the case 5/ is not very well described too, maybe we should
> add something about it.
> 
> Thanks,
> Olivier

The patch does help clarify the meaning, and Oliver's summary clarifies
even more. It might be possible for hardware to offload inner vlan but
not outer vlan, though seriously doubt anyone but some conformance test
would do that.
 

  reply	other threads:[~2020-02-26  0:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06  8:34 Somnath Kotur
2020-02-06 16:27 ` Somnath Kotur
2020-02-06 17:25 ` Olivier Matz
2020-02-07 13:43   ` Somnath Kotur
2020-02-07 14:29     ` Olivier Matz
2020-02-26  0:55       ` Stephen Hemminger [this message]
2020-04-24 18:24         ` Thomas Monjalon
2020-05-24 15:34           ` Thomas Monjalon
2020-06-11  6:11             ` Thomas Monjalon
2020-04-25 13:08 ` Andrew Rybchenko
2020-10-06  7:22 ` [dpdk-dev] [PATCH v2] mbuf: extend meaning of QinQ stripped bit Olivier Matz
2020-10-08 13:13   ` David Marchand
2020-10-12  8:20   ` Andrew Rybchenko
2020-10-15 20:58   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200225165541.01c06952@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=somnath.kotur@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git