From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B63F5A0566; Mon, 2 Mar 2020 11:53:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89BBE1BFF6; Mon, 2 Mar 2020 11:53:20 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9116B2E81; Mon, 2 Mar 2020 11:53:18 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 02:53:17 -0800 X-IronPort-AV: E=Sophos;i="5.70,506,1574150400"; d="scan'208";a="233119364" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.49]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 02 Mar 2020 02:53:16 -0800 Date: Mon, 2 Mar 2020 10:53:13 +0000 From: Bruce Richardson To: agupta3@marvell.com Cc: Harman Kalra , dev@dpdk.org, stable@dpdk.org Message-ID: <20200302105313.GA1603@bricha3-MOBL.ger.corp.intel.com> References: <1581925669-15294-1-git-send-email-agupta3@marvell.com> <1583130716-28360-1-git-send-email-agupta3@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583130716-28360-1-git-send-email-agupta3@marvell.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 02, 2020 at 12:01:55PM +0530, agupta3@marvell.com wrote: > From: Amit Gupta > > Add a additional condition to check if all required internal > dependencies are met before building octeontx drivers using meson. > > Bugzilla ID: 387 > > Fixes: 7f615033d64f ("drivers/net: build Cavium NIC PMDs with meson") > > Signed-off-by: Amit Gupta > --- > v2: > - rebased to v20.02 > - upstream comments incorporated. > > drivers/net/octeontx/base/meson.build | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/octeontx/base/meson.build b/drivers/net/octeontx/base/meson.build > index a06a2c8..035aeda 100644 > --- a/drivers/net/octeontx/base/meson.build > +++ b/drivers/net/octeontx/base/meson.build > @@ -10,7 +10,11 @@ sources = [ > depends = ['ethdev', 'mempool_octeontx'] > static_objs = [] > foreach d: depends > - static_objs += [get_variable('static_rte_' + d)] > + test_dep_obj = '@0@'.format(get_variable('static_rte_' + d, '')) > + if test_dep_obj == '' > + subdir_done() > + endif > + static_objs += get_variable('static_rte_' + d) > endforeach very minor nit - you can use "test_dep_obj" here rather than calling get_variable twice. /Bruce