From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 670DFA056F; Tue, 3 Mar 2020 02:58:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F5C81BFF3; Tue, 3 Mar 2020 02:58:23 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 074EA1BFF0; Tue, 3 Mar 2020 02:58:20 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 17:58:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,509,1574150400"; d="scan'208";a="239880848" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga003.jf.intel.com with ESMTP; 02 Mar 2020 17:58:18 -0800 Date: Tue, 3 Mar 2020 09:56:07 +0800 From: Ye Xiaolong To: Qiming Yang Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20200303015607.GD25927@intel.com> References: <20200226092221.85536-1-qiming.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226092221.85536-1-qiming.yang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix X722 performance drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Qiming On 02/26, Qiming Yang wrote: >GL_SWR_PM_UP_THR value lack in X722 caused configure register write not be >called. This is the root cause of performance drop. This patch add support >for: Could you elaborate what kind of performance drop caused by the missing register cfg? Thanks, Xiaolong > > Device-ID Value Comments > 0x37D0 0x03030303 4x10G FPK > >Fixes: 3320d4a240da ("net/i40e: workaround performance degradation") >Cc: stable@dpdk.org > >Signed-off-by: Qiming Yang >--- > drivers/net/i40e/i40e_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >index 9fbda1c..c09b9b9 100644 >--- a/drivers/net/i40e/i40e_ethdev.c >+++ b/drivers/net/i40e/i40e_ethdev.c >@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) > { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) }, > { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) }, > { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) }, >+ { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) }, > > { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) }, > { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) }, >-- >2.9.5 >