DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Amit Gupta <agupta3@marvell.com>
Cc: Harman Kalra <hkalra@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers
Date: Tue, 3 Mar 2020 11:17:05 +0000	[thread overview]
Message-ID: <20200303111705.GA1557@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <MWHPR1801MB1934F192814B539BA5F806B1FDE40@MWHPR1801MB1934.namprd18.prod.outlook.com>

On Tue, Mar 03, 2020 at 03:10:56AM +0000, Amit Gupta wrote:
> 
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Monday, March 2, 2020 4:23 PM
> > To: Amit Gupta <agupta3@marvell.com>
> > Cc: Harman Kalra <hkalra@marvell.com>; dev@dpdk.org; stable@dpdk.org
> > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson build
> > for disabled octeontx drivers
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > On Mon, Mar 02, 2020 at 12:01:55PM +0530, agupta3@marvell.com wrote:
> > > From: Amit Gupta <agupta3@marvell.com>
> > >
> > > Add a additional condition to check if all required internal
> > > dependencies are met before building octeontx drivers using meson.
> > >
> > > Bugzilla ID: 387
> > >
> > > Fixes: 7f615033d64f ("drivers/net: build Cavium NIC PMDs with meson")
> > >
> > > Signed-off-by: Amit Gupta <agupta3@marvell.com>
> > > ---
> > > v2:
> > >  - rebased to v20.02
> > >  - upstream comments incorporated.
> > >
> > >  drivers/net/octeontx/base/meson.build | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/octeontx/base/meson.build
> > > b/drivers/net/octeontx/base/meson.build
> > > index a06a2c8..035aeda 100644
> > > --- a/drivers/net/octeontx/base/meson.build
> > > +++ b/drivers/net/octeontx/base/meson.build
> > > @@ -10,7 +10,11 @@ sources = [
> > >  depends = ['ethdev', 'mempool_octeontx']  static_objs = []  foreach
> > > d: depends
> > > -	static_objs += [get_variable('static_rte_' + d)]
> > > +	test_dep_obj = '@0@'.format(get_variable('static_rte_' + d, ''))
> > > +	if test_dep_obj == ''
> > > +		subdir_done()
> > > +	endif
> > > +	static_objs += get_variable('static_rte_' + d)
> > >  endforeach
> > 
> > very minor nit - you can use "test_dep_obj" here rather than calling
> > get_variable twice.
> > 
> test_dep_obj is being formatted as string object, so can't be used as static obj..

Apologies, you are quite right, I missed that.

One final suggestion - the "is_variable" function is probably want you want
rather than using get_variable with a fallback. It should save the use of a
temporary variable completely.

/Bruce

  reply	other threads:[~2020-03-03 11:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17  7:47 [dpdk-dev] [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled agupta3
2020-02-17  9:54 ` David Marchand
2020-02-19  4:34   ` [dpdk-dev] [EXT] " Amit Gupta
2020-02-17 10:48 ` [dpdk-dev] " Bruce Richardson
2020-02-19  4:32   ` [dpdk-dev] [EXT] " Amit Gupta
2020-03-02  6:31 ` [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers agupta3
2020-03-02 10:53   ` Bruce Richardson
2020-03-03  3:10     ` [dpdk-dev] [EXT] " Amit Gupta
2020-03-03 11:17       ` Bruce Richardson [this message]
2020-03-04  5:47         ` Amit Gupta
2020-03-04  5:47   ` [dpdk-dev] [PATCH v3 " agupta3
2020-03-04 13:49     ` Bruce Richardson
2020-04-05 11:57       ` Jerin Jacob
2020-04-06 10:03     ` Harman Kalra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303111705.GA1557@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=agupta3@marvell.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).