From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A9DFA0573; Thu, 5 Mar 2020 11:47:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 932601BE7D; Thu, 5 Mar 2020 11:47:01 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2088.outbound.protection.outlook.com [40.107.22.88]) by dpdk.org (Postfix) with ESMTP id 652C42BE3; Thu, 5 Mar 2020 11:47:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HEEXJhDXfnrHSMM38dcrJpli41AkillF2+jG/YMh+ygVXwmVK3N/7PnP0V8T1W58rU2mBeWC01oTnq761S7aIxgkn5tgj17kY++mkRtfgSk7XhNv/cco3f/Usv6sMTDxkxy9VEA6rt1tOq9yiqm6/4BqDmgriqLH2g9RmzznHcyBGY7vsXws9zEMKTKmvxk0rWf8Tls5hRnHbE12CXzNFsyB4QdyYf0hLO3jrwxyASDN1TYnFp1sy+H+F7zZ99VgTu0VWtdT4tbIBGsGQqkpl24wPsvNrBI8Nph7SLnEvMbnRn48MD2P9qb3BdSaNglhv/sZbkFOOtF8bWkmFXWTzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhiMjGy95+CB8ew6Frvtru1sgo1hCuk5YT+rKScRLFk=; b=NUlzIMBNOJn8pw4VH77qfYcFiHMFKobSGn++kPioMAHDsfGFHnmXgcLD2iWFOtE4Bb09DfdpyuxsNwJNW+Qf44tvScdz8QyU1PGxMRagGVhiiPPDd2cgySgwBJLefMSBuPF/rHafl7xTNak7/UUXj4li2iG6qftyS05uN0fy1ICGn1yldsgyfIonW5VhRg3Ambyb4lLfZ2X9NE9UU8sL7yexPC0wmn7ko7Ghfgk1ew6R7SykMmakenaTWZeBrRFFo8INCCT8U33qwRPVSbWFio3oipptZgSqaoHoxDSUBH3M7SQyCJFSHyuSHYB9kY/TXHbdkn9leQAEzWR2Z6LToQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=paloaltonetworks.com smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=none pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhiMjGy95+CB8ew6Frvtru1sgo1hCuk5YT+rKScRLFk=; b=qYbhLNujRDcD11ShW7aiS+6i+0OsXR/Yw9KhRXeQ24oP9E/+OZNtADcUre8F5sLtjy/pADBy7ZOYj/ah6xOjIraU6mTRAPTcbKXuwqvCVO41SxIx66DB/LNz85okRD0mo4BcUyOcsRn52RbBTWsrSl+wNxpr1a4LiWDOOyURkBY= Received: from AM6PR05CA0018.eurprd05.prod.outlook.com (2603:10a6:20b:2e::31) by AM0PR0702MB3714.eurprd07.prod.outlook.com (2603:10a6:208:26::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.11; Thu, 5 Mar 2020 10:46:58 +0000 Received: from HE1EUR02FT033.eop-EUR02.prod.protection.outlook.com (2603:10a6:20b:2e:cafe::6) by AM6PR05CA0018.outlook.office365.com (2603:10a6:20b:2e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.15 via Frontend Transport; Thu, 5 Mar 2020 10:46:58 +0000 Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; paloaltonetworks.com; dkim=none (message not signed) header.d=none;paloaltonetworks.com; dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; Received: from oa.msg.ericsson.com (192.176.1.74) by HE1EUR02FT033.mail.protection.outlook.com (10.152.10.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2793.11 via Frontend Transport; Thu, 5 Mar 2020 10:46:58 +0000 Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESSMR506.ericsson.se (153.88.183.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 5 Mar 2020 11:46:55 +0100 Received: from selio1a020.lmera.ericsson.se (153.88.183.153) by smtp.internal.ericsson.com (153.88.183.185) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 5 Mar 2020 11:46:55 +0100 Received: from breslau.lmera.ericsson.se (breslau.lmera.ericsson.se [150.132.109.241]) by selio1a020.lmera.ericsson.se (8.15.1+Sun/8.15.1) with ESMTP id 025Aktrq008090; Thu, 5 Mar 2020 11:46:55 +0100 (CET) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , , , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Date: Thu, 5 Mar 2020 11:46:51 +0100 Message-ID: <20200305104651.25456-1-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.176.1.74; IPV:; CTRY:SE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(346002)(376002)(39860400002)(199004)(189003)(107886003)(4326008)(70586007)(70206006)(5660300002)(36756003)(336012)(54906003)(316002)(2906002)(1076003)(6916009)(7636002)(86362001)(956004)(6666004)(356004)(2616005)(4744005)(186003)(246002)(8676002)(26005)(478600001)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0702MB3714; H:oa.msg.ericsson.com; FPR:; SPF:Pass; LANG:en; PTR:office365.se.ericsson.net; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab29ffe0-6dc3-449e-3679-08d7c0f2877c X-MS-TrafficTypeDiagnostic: AM0PR0702MB3714: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1186; X-Forefront-PRVS: 03333C607F X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JlQJQv8bAqdHaYAgPetXgYJkEhLVAiCXeS7k89pQrsHtVTXB/6rRWa3UiX8bb/VvqVoF8RGwM98sGsLvWB+7D4OvbWzb5Hmcrg3yXo2lHrjrA+9cIrXbPLZb0SV+JHNr05pc/sOnFux1exg9LWadKp8n+xl4gvI4NGi7pg+kc9bvnaWjI+c87LWf2263gTVgYTIL45LWI+v+a0WWEXJ7pW3tVS2tsHLXS6mLcpIpw75eJH5/qYhEmIi5tREwsD/MegTiT4Pv012Y3m+3h7aqbAuqMWm136jeH8T/v61xBQAmFkTajTtL3sCEHg23ZBlXRluPzAZZzPldf/NjEHam73NAkyBstYmEXpy5RJ2lDXG1CbfM/WgiczAH1pHSk0wy0nw0N9zQeOq2X9GKOis5cGA/DIj6Y7CFTH+FyC04Wb8dO6QUwzNQdnvNQoWRLlqO X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2020 10:46:58.3557 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab29ffe0-6dc3-449e-3679-08d7c0f2877c X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0702MB3714 Subject: [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Avoid reusing recorded events when performing a migration, since this may make the migration selection logic pick an already-moved flow. Fixes: f6257b22e767 ("event/dsw: add load balancing") Cc: stable@dpdk.org Reported-by: Venky Venkatesh Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c index d68b71b98..296adea18 100644 --- a/drivers/event/dsw/dsw_event.c +++ b/drivers/event/dsw/dsw_event.c @@ -646,6 +646,9 @@ dsw_port_consider_migration(struct dsw_evdev *dsw, if (dsw->num_ports == 1) return; + if (seen_events_len < DSW_MAX_EVENTS_RECORDED) + return; + DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering migration.\n"); /* Randomize interval to avoid having all threads considering -- 2.17.1