Re: [dpdk-dev] [PATCH] net/bnxt: allow configuring vector mode

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 5 Mar 2020 15:10:48 -0500
Lance Richardson <lance.richardson@broadcom.com> wrote:

> Hi Stephen,
> 
> On Thu, Mar 5, 2020 at 1:45 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >  
> <snip>
> >
> > Make the configuration use the same as other drivers with
> > vector mode: ixge, i40e, ...  
> s/ixge/ixgbe/?
> 
> >  
> <snip>
> > This will also make future support of vector mode on other
> > architectures possible.
> >
> > Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")  
> <snip>
> > +#error "bnxt: IEEE1588 is incompatiable with vector mode"
> > +#endif  
> s/incompatiable/incompatible/
> 
> 
> This was this approach taken in the initial patch set to add bnxt
> vector mode support,
> however based on feedback the current approach was used instead. That discussion
> can be found here:
>       http://patches.dpdk.org/patch/53683/
> 
> If mark support could be treated as a receive offload, it would be
> possible to choose
> the non-vector receive handler based on whether mark is enabled. Adding a kvargs
> option to disable vector mode might be another possibility. Otherwise,
> a build-time
> configuration option does seem to be useful.
> 
> LGTM... with the above:
> 
> Acked-by: Lance Richardson <lance.richardson@broadcom.com>

What ever solution must be consistent across all drivers.