From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4CACA056A; Thu, 5 Mar 2020 23:18:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0D852BB8; Thu, 5 Mar 2020 23:18:16 +0100 (CET) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id B63F22BB8 for ; Thu, 5 Mar 2020 23:18:14 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id y30so77875pga.13 for ; Thu, 05 Mar 2020 14:18:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K2hJ2iQa45ijK0L51doVq9q+G6oFIroIBt4/57iYJiE=; b=PX1qJ+bwKxsTPZwvpXbEeobvvnVNxnZhM/ILxnw6o5YDcXD3LJ9ZUwKKVikQDP5X3V +MXMIv/HO4JXhPFDPeuwAh0fXBACIKh98Fzs1D9JtxuULGTU8iWk0G6K4oymZhKZQivv rrYtNctZJXo1DQaHz5DL9cN4YI8g8dJEyNNOea2kIo3NDLdvajxM8dAkMnrO9TbacbUp RJztm9doAqL4CrNaowGTMol3y5XtOipCIoGTIm92PUg4T/99aUSDzs6Q/IJ7p8x7BK0o oIfHgXC0C8rInSsfu36FGG15JjQCetoZhD0USwru5ief4faWp7mEv+WpzDC5Op10Y+cN XV1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K2hJ2iQa45ijK0L51doVq9q+G6oFIroIBt4/57iYJiE=; b=caJqpFfQGGebxu+ZA2GSPut8BIpPxNCzaGmV9ApsUyCmYoHn7UvQSZk6oQX/7lGDg4 Mf4tQkDcjwmUlmRKY9Y/FeA/q2itBi2NmNcpoQin00eJXh1xDXsBz8G5T4PGxYTaxFsE b/Up5hkjqcLom6lujDhzQffDiXp3tr6IPIlO8NSW2Vj4GZ6UTWkFGfvqdAONVpJpnh2l l/vVUEdYfUPZzxMuz5Bh/BT94mk5qZPq50XjgzEcp4R/T/ZrJBRYsbyZXFONegi3VoF7 W2w8G/QCLkKfsgnrbgWjSjnqd+ewRIokAHjqB12qtcina2e3FlhJLMWpTxhF/oYtapGL Q3QA== X-Gm-Message-State: ANhLgQ1mwZHH4avjT4O7px/8PxMBm1Y7hULQQ6qTNKgQsIuSlrc1K3Xs qenLvtl1z7Q77v/4Uik4wH4eMg== X-Google-Smtp-Source: ADFU+vuFrln22qVScjlciov45CkitKLjwllmzbxcbO9QHAU54qfq83/mDe4ASAP5dK/8rTTmuzPsOQ== X-Received: by 2002:a65:624c:: with SMTP id q12mr286074pgv.380.1583446692235; Thu, 05 Mar 2020 14:18:12 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r145sm34341955pfr.5.2020.03.05.14.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 14:18:11 -0800 (PST) Date: Thu, 5 Mar 2020 14:18:09 -0800 From: Stephen Hemminger To: Lance Richardson Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20200305141809.68d7772b@hermes.lan> In-Reply-To: References: <20200305064500.5634-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bnxt: allow configuring vector mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 5 Mar 2020 15:10:48 -0500 Lance Richardson wrote: > Hi Stephen, > > On Thu, Mar 5, 2020 at 1:45 AM Stephen Hemminger > wrote: > > > > > > > Make the configuration use the same as other drivers with > > vector mode: ixge, i40e, ... > s/ixge/ixgbe/? > > > > > > This will also make future support of vector mode on other > > architectures possible. > > > > Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode") > > > +#error "bnxt: IEEE1588 is incompatiable with vector mode" > > +#endif > s/incompatiable/incompatible/ > > > This was this approach taken in the initial patch set to add bnxt > vector mode support, > however based on feedback the current approach was used instead. That discussion > can be found here: > http://patches.dpdk.org/patch/53683/ > > If mark support could be treated as a receive offload, it would be > possible to choose > the non-vector receive handler based on whether mark is enabled. Adding a kvargs > option to disable vector mode might be another possibility. Otherwise, > a build-time > configuration option does seem to be useful. > > LGTM... with the above: > > Acked-by: Lance Richardson What ever solution must be consistent across all drivers.