DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vlad Zolotarov <vladz@scylladb.com>
To: dev@dpdk.org
Cc: Vlad Zolotarov <vladz@scylladb.com>
Subject: [dpdk-dev] [PATCH v1] ena_ethdev: don't override the user provided queue length value
Date: Thu,  5 Mar 2020 17:23:33 -0500	[thread overview]
Message-ID: <20200305222333.18784-1-vladz@scylladb.com> (raw)

There is a funny logic that seems to be outdated which tries to detect
a situation when a user requests a default size of the queue and
configures a device specific default value.

This seems to be not in line with the DPDK current design that expects
the user to go via the rte_eth_dev_info_get() in order to get device
specific values.

And if the user doesn't care it should pass 0 as a queue length and this
case is also being taken care of on the rte_eth level.

Signed-off-by: Vlad Zolotarov <vladz@scylladb.com>
---
 drivers/net/ena/ena_ethdev.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 665afee4f..bf632dee0 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1221,9 +1221,6 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,
 		return -EINVAL;
 	}
 
-	if (nb_desc == RTE_ETH_DEV_FALLBACK_TX_RINGSIZE)
-		nb_desc = adapter->tx_ring_size;
-
 	txq->port_id = dev->data->port_id;
 	txq->next_to_clean = 0;
 	txq->next_to_use = 0;
@@ -1292,9 +1289,6 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,
 		return ENA_COM_FAULT;
 	}
 
-	if (nb_desc == RTE_ETH_DEV_FALLBACK_RX_RINGSIZE)
-		nb_desc = adapter->rx_ring_size;
-
 	if (!rte_is_power_of_2(nb_desc)) {
 		PMD_DRV_LOG(ERR,
 			"Unsupported size of RX queue: %d is not a power of 2.\n",
-- 
2.20.1


             reply	other threads:[~2020-03-05 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 22:23 Vlad Zolotarov [this message]
2020-03-05 22:28 ` Vladislav Zolotarov
2020-03-09 10:07   ` Chauskin, Igor
2020-03-11 13:30     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200305222333.18784-1-vladz@scylladb.com \
    --to=vladz@scylladb.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).