DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: dev@dpdk.org
Cc: Kevin Traynor <ktraynor@redhat.com>,
	stable@dpdk.org,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Radu Nicolau <radu.nicolau@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>
Subject: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning
Date: Wed, 11 Mar 2020 11:33:00 +0000	[thread overview]
Message-ID: <20200311113300.32487-2-ktraynor@redhat.com> (raw)
In-Reply-To: <20200311113300.32487-1-ktraynor@redhat.com>

gcc 10.0.1 reports:

../examples/ipsec-secgw/ipsec_process.c: In function ‘ipsec_process’:
../examples/ipsec-secgw/ipsec_process.c:132:34:
error: ‘grp.m’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  132 |    grp[n].cnt = pkts + i - grp[n].m;
      |                            ~~~~~~^~

This is a correct warning for the initial execution of the statement.
However, it is the design of the loop that grp[0].cnt will later be
written with the correct value using an initialized grp[0].m before it
is used.

In order to remove the warning, initialize grp[0].m for the initial and
unused calculation of grp[0].cnt.

Fixes: 3e5f4625dc17 ("examples/ipsec-secgw: make data-path to use IPsec library")
Cc: stable@dpdk.org

Suggested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
v2: just initialize grp[0].m instead of the full array.

note, commit log violates line length but I didn't want to split warning msg.

Cc: konstantin.ananyev@intel.com
Cc: Radu Nicolau <radu.nicolau@intel.com>
Cc: Akhil Goyal <akhil.goyal@nxp.com>
---
 examples/ipsec-secgw/ipsec_process.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/ipsec_process.c
index bb2f2b82d..6d3a3c9a1 100644
--- a/examples/ipsec-secgw/ipsec_process.c
+++ b/examples/ipsec-secgw/ipsec_process.c
@@ -127,4 +127,5 @@ sa_group(void *sa_ptr[], struct rte_mbuf *pkts[],
 
 	sa = nosa;
+	grp[0].m = pkts;
 	for (i = 0, n = 0; i != num; i++) {
 
-- 
2.21.1


  reply	other threads:[~2020-03-11 11:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  9:37 [dpdk-dev] [PATCH 1/2] net/avp: " Kevin Traynor
2020-02-20  9:37 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-gw: " Kevin Traynor
2020-02-26  6:12   ` Akhil Goyal
2020-03-10 13:08   ` Ananyev, Konstantin
2020-03-10 18:52     ` Kevin Traynor
2020-03-10 19:03       ` Ananyev, Konstantin
2020-03-11 11:32 ` [dpdk-dev] [PATCH v2 1/2] net/avp: " Kevin Traynor
2020-03-11 11:33   ` Kevin Traynor [this message]
2020-03-11 12:04     ` [dpdk-dev] [PATCH v2 2/2] examples/ipsec-gw: " Ananyev, Konstantin
2020-05-06  9:18       ` David Marchand
2020-03-11 23:56   ` [dpdk-dev] [PATCH v2 1/2] net/avp: " Webster, Steven
2020-05-06  9:18     ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-03-12 13:25   ` [dpdk-dev] " Ferruh Yigit
2020-03-12 14:18     ` Kevin Traynor
2020-03-12 14:31       ` Ferruh Yigit
2020-03-12 15:15         ` Kevin Traynor
2020-03-12 16:47           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311113300.32487-2-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=radu.nicolau@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).