From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9B9DA056A; Wed, 11 Mar 2020 12:33:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24A591C012; Wed, 11 Mar 2020 12:33:37 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 33C2D1C00E for ; Wed, 11 Mar 2020 12:33:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583926414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h9S7Wc0/Cv5kWclwzkqdXFMI7SKEfSAISpVGboMLZCc=; b=Sy5jb9hNLnyTnIyVXAz165uRt2nUY2R5nhV3mLqnHzptd5nn2SGVAEHNJRs+0jzmvBWLjv lDkfLp22JMt6MGsSQlu0TtTNQIZTfH7zR+EenWChfS6CtnSVlYhp9fynA2uEUtveCJ3+NN TlVAzd7IeZ9Q7UXLzgSVp0PlFj3/8QQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-El2dPh4tPqK5Ypn0C8HUYA-1; Wed, 11 Mar 2020 07:33:33 -0400 X-MC-Unique: El2dPh4tPqK5Ypn0C8HUYA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CFCF6802683; Wed, 11 Mar 2020 11:33:31 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 028EF60BF4; Wed, 11 Mar 2020 11:33:26 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: Kevin Traynor , stable@dpdk.org, Konstantin Ananyev , Radu Nicolau , Akhil Goyal Date: Wed, 11 Mar 2020 11:33:00 +0000 Message-Id: <20200311113300.32487-2-ktraynor@redhat.com> In-Reply-To: <20200311113300.32487-1-ktraynor@redhat.com> References: <20200220093744.13925-1-ktraynor@redhat.com> <20200311113300.32487-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" gcc 10.0.1 reports: ../examples/ipsec-secgw/ipsec_process.c: In function =E2=80=98ipsec_process= =E2=80=99: ../examples/ipsec-secgw/ipsec_process.c:132:34: error: =E2=80=98grp.m=E2=80=99 may be used uninitialized in this function [= -Werror=3Dmaybe-uninitialized] 132 | grp[n].cnt =3D pkts + i - grp[n].m; | ~~~~~~^~ This is a correct warning for the initial execution of the statement. However, it is the design of the loop that grp[0].cnt will later be written with the correct value using an initialized grp[0].m before it is used. In order to remove the warning, initialize grp[0].m for the initial and unused calculation of grp[0].cnt. Fixes: 3e5f4625dc17 ("examples/ipsec-secgw: make data-path to use IPsec lib= rary") Cc: stable@dpdk.org Suggested-by: Konstantin Ananyev Signed-off-by: Kevin Traynor --- v2: just initialize grp[0].m instead of the full array. note, commit log violates line length but I didn't want to split warning ms= g. Cc: konstantin.ananyev@intel.com Cc: Radu Nicolau Cc: Akhil Goyal --- examples/ipsec-secgw/ipsec_process.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/ip= sec_process.c index bb2f2b82d..6d3a3c9a1 100644 --- a/examples/ipsec-secgw/ipsec_process.c +++ b/examples/ipsec-secgw/ipsec_process.c @@ -127,4 +127,5 @@ sa_group(void *sa_ptr[], struct rte_mbuf *pkts[], =20 =09sa =3D nosa; +=09grp[0].m =3D pkts; =09for (i =3D 0, n =3D 0; i !=3D num; i++) { =20 --=20 2.21.1