From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DF50A056D; Fri, 13 Mar 2020 02:20:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B29DD1BFA5; Fri, 13 Mar 2020 02:20:12 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AEE0A2BE6 for ; Fri, 13 Mar 2020 02:20:10 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 18:20:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,546,1574150400"; d="scan'208";a="232257798" Received: from hyperscan.sh.intel.com (HELO hyperscan) ([10.67.104.81]) by orsmga007.jf.intel.com with ESMTP; 12 Mar 2020 18:20:02 -0700 Date: Fri, 13 Mar 2020 09:20:27 +0800 From: Wang Xiang To: Ori Kam Cc: jerinj@marvell.com, dev@dpdk.org, pbhagavatula@marvell.com, shahafs@mellanox.com, hemant.agrawal@nxp.com, opher@mellanox.com, alexr@mellanox.com, dovrat@marvell.com, pkapoor@marvell.com, nipun.gupta@nxp.com, bruce.richardson@intel.com, yang.a.hong@intel.com, harry.chang@intel.com, gu.jian1@zte.com.cn, shanjiangh@chinatelecom.cn, zhangy.yun@chinatelecom.cn, lixingfu@huachentel.com, wushuai@inspur.com, yuyingxia@yxlink.com, fanchenggang@sunyainfo.com, davidfgao@tencent.com, liuzhong1@chinaunicom.cn, zhaoyong11@huawei.com, oc@yunify.com, jim@netgate.com, hongjun.ni@intel.com, j.bromhead@titan-ic.com, deri@ntop.org, fc@napatech.com, arthur.su@lionic.com, thomas@monjalon.net Message-ID: <20200313012027.GA25215@hyperscan> References: <20190627155036.56940-1-jerinj@marvell.com> <1583836353-42867-1-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583836353-42867-1-git-send-email-orika@mellanox.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, Sorry for the late response as I am occupied by other works. Two comments below to make the definitions compatible to Hyperscan. Thanks, Xiang On Tue, Mar 10, 2020 at 10:32:33AM +0000, Ori Kam wrote: > +#define RTE_REGEX_PCRE_RULE_MATCH_ALL_F (1ULL << 13) > +/**< This flag marks that the results for the pattern that is being compiled > + * should include all possible matches. > + * @see struct rte_regex_dev_info::rule_flags, struct rte_regex_rule::rule_flags > + */ > + Can we change this flag to RTE_REGEX_DEV_CFG_MATCH_ALL since Hyperscan only supports match all mode and users don't have to specify this flag per rule? > + */ > +__rte_experimental > +int > +rte_regex_dev_info_get(uint8_t dev_id, struct rte_regex_dev_info *dev_info); > + > +/* Enumerates RegEx device configuration flags */ > +#define RTE_REGEX_DEV_CFG_CROSS_BUFFER_SCAN_F (1ULL << 0) > +/**< Cross buffer scan refers to the ability to be able to detect > + * matches that occur across buffer boundaries, where the buffers are related > + * to each other in some way. Enable this flag when to scan payload size > + * greater than struct rte_regex_dev_info::max_payload_size and/or > + * matches can present across scan buffer boundaries. > + * > + * @see struct rte_regex_dev_info::max_payload_size > + * @see struct rte_regex_dev_config::dev_cfg_flags, rte_regex_dev_configure() > + * @see RTE_REGEX_OPS_RSP_PMI_SOJ_F > + * @see RTE_REGEX_OPS_RSP_PMI_EOJ_F > + * @see RTE_REGEX_OPS_RSP_PMI_TOJ_F > + */ > + Can we add another flag RTE_REGEX_DEV_CFG_CROSS_BUFFER_SCAN_FULL_F? In this case, we only return full match for cross buffer scan without any partial result and without returning response flags such as RTE_REGEX_OPS_RSP_PMI_*.