From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Pallavi Kadam <pallavi.kadam@intel.com>,
dev@dpdk.org, ranjit.menon@intel.com, talshn@mellanox.com,
narcisa.vasile@microsoft.com
Subject: Re: [dpdk-dev] [PATCH 2/2] build: add module definitions and pci lib support
Date: Wed, 18 Mar 2020 03:28:48 +0300 [thread overview]
Message-ID: <20200318032848.3b6e1d1a@Sovereign> (raw)
In-Reply-To: <10706758.F0gNSz5aLb@xps>
> 17/03/2020 01:48, Pallavi Kadam:
> > Added mman functions to eal exports list.
> [...]
> > --- a/lib/librte_eal/rte_eal_exports.def
> > +++ b/lib/librte_eal/rte_eal_exports.def
>
> This file is generated. Only the .map can be updated.
A minor correction: this file is not generated, it overrides generation of
*.def from *.map, see buildtools/map_to_def.py.
> > @@ -7,3 +7,5 @@ EXPORTS
> > rte_eal_remote_launch
> > rte_log
> > rte_vlog
> > + mmap
> > + munmap
>
> These functions should not be exported for Linux.
>
> And in general, I think it would be better to state what is
> the memory management strategy on Windows first.
> Maybe we will need to use a different abstraction.
I concur, this patch should be postponed at least. Hopefully we'll settle
to something regarding Windows MM at the nearest Community Call.
EAL will have to export mmap/munmap-like functions for mapping files and
anonymous pages to support library code. Depending on the approach to MM
implementation for Windows, not all mmap() calls may even translate into its
Win32 equivalent. For example, hugepage allocation on Windows will use
different approach that MMF.
Mapping device BARs can only be done using IOCTLs on Windows, so
rte_pci_map/unmap_resource() code will not work even if it compiles.
--
Dmitry Kozlyuk
prev parent reply other threads:[~2020-03-18 0:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 0:48 [dpdk-dev] [PATCH 0/2] Support librte_pci on Windows Pallavi Kadam
2020-03-17 0:48 ` [dpdk-dev] [PATCH 1/2] eal: mman implementation for windows Pallavi Kadam
2020-03-17 0:48 ` [dpdk-dev] [PATCH 2/2] build: add module definitions and pci lib support Pallavi Kadam
2020-03-17 9:31 ` Thomas Monjalon
2020-03-18 0:28 ` Dmitry Kozlyuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318032848.3b6e1d1a@Sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=narcisa.vasile@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).